From dev-return-90899-archive-asf-public=cust-asf.ponee.io@httpd.apache.org Thu Jan 18 15:54:23 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E208518066D for ; Thu, 18 Jan 2018 15:54:23 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D223A160C2B; Thu, 18 Jan 2018 14:54:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2821C160C36 for ; Thu, 18 Jan 2018 15:54:23 +0100 (CET) Received: (qmail 51763 invoked by uid 500); 18 Jan 2018 14:54:21 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 51521 invoked by uid 99); 18 Jan 2018 14:54:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jan 2018 14:54:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6227B180981 for ; Thu, 18 Jan 2018 14:54:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.821 X-Spam-Level: X-Spam-Status: No, score=-0.821 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id T5WUm4O4YsQY for ; Thu, 18 Jan 2018 14:54:20 +0000 (UTC) Received: from mail-qt0-f182.google.com (mail-qt0-f182.google.com [209.85.216.182]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 0B1185F343 for ; Thu, 18 Jan 2018 14:54:20 +0000 (UTC) Received: by mail-qt0-f182.google.com with SMTP id x27so22774407qtm.12 for ; Thu, 18 Jan 2018 06:54:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=93ZfvIrTPZqBa/1qCVR2II367pXxJ1ddZUI7f44Cxys=; b=TlZj66Hbo/ivTsDMn9o7uUQJcgkXdEUFtCJjAeFrWIOtjR3okOCfM079iEHemYX5Th L9y7lWcd9nSfHrd+mNsPIuQq3oVwfFO2NLCbp79G9T/J0hmjFJnsQKWolJNLihk/eho1 d94qnWk7Z2M4C/nX3lW8RU0e5qrgUZc+Qqkz/tMoe/QHRJ5gaej6THqL7Yq3ZlM7ofl7 QeNuK17nj4tZtcDwtmHbN7I2lriw4LaqCzczSEpSrFWPHD2x8wEXNY3fdtjVs5WfGOq2 eNJuJ8WiTvMrtUVECenp6sqYUV2ihTNJmZJd3fsZAr8NH3cDL6r74LS+HEe+iZF7/0Ic tTow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=93ZfvIrTPZqBa/1qCVR2II367pXxJ1ddZUI7f44Cxys=; b=WTFeNMf4UcimGBZZYXslzog3+XSfnwT9VS5/M+dLB68EX9xK72PCwK/rbv1WDUyWXS cjIq6UZMy9BwOFDUwrydIn1erOuYilA5rz+NtCw1GI//963za/ZTi1rQSrdkzu1BQNW+ EnftcVi/LdyB+YnBDdzHDRuGG7qWk8H4GxzEGPfq+2OH63WhPT2kaDNnVfc8wAtTo9sr hveqnoo7qdQNo9UZYX6MugrDRKAjdYEmyYCkzAEROniQy6P573aQ4Upd54xJ9Jjr1cGD Ri7IvmNIgvFUwBWarnz7/KwmDYsED4KRr1MDwUKF0HldQW9Zz2G5j9BB8iDMEJgvFYCk z32g== X-Gm-Message-State: AKwxytcG21iPJFIbYECLvdOQbd6ifJLi2bJY7SC9CTBUh3Ooe8ZTVaXO axMzf/y/W/d1ylRLP3kxBco6F7WvnEaYcTveXjU= X-Google-Smtp-Source: ACJfBotssKmzG0exgN9jR9BPUW1h+fxqbPYFP96CRc/YnsNptxEHofJWZzkcdA1pfV48Tm3QF7/Szkakrm/HZRqP60s= X-Received: by 10.237.49.199 with SMTP id 65mr21844123qth.12.1516287258775; Thu, 18 Jan 2018 06:54:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.55.27.144 with HTTP; Thu, 18 Jan 2018 06:54:18 -0800 (PST) In-Reply-To: <932f08a6-6b08-f9e9-ce09-8c1bdd027922@apache.org> References: <20180118141931.454203A00AF@svn01-us-west.apache.org> <932f08a6-6b08-f9e9-ce09-8c1bdd027922@apache.org> From: Yann Ylavic Date: Thu, 18 Jan 2018 15:54:18 +0100 Message-ID: Subject: Re: svn commit: r1821499 - in /httpd/httpd/trunk: CHANGES server/mpm/event/event.c server/mpm/worker/worker.c To: httpd-dev Content-Type: text/plain; charset="UTF-8" On Thu, Jan 18, 2018 at 3:43 PM, Ruediger Pluem wrote: > > Is there a reason why ap_run_child_init and the skiplist stuff are now in reverse order? Nope, I realized that afterward, and actually if some child_init() plays with event's timers that will crash. So I reverted and re-commited without this change (which also helps backport btw). Thanks for the review, Yann.