httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1822341 - in /httpd/httpd/trunk: CHANGES modules/slotmem/mod_slotmem_shm.c
Date Mon, 29 Jan 2018 14:36:10 GMT
Thanks, r1822509 seems to work for me.

On Mon, Jan 29, 2018 at 2:46 PM, Jim Jagielski <jim@jagunet.com> wrote:
> OK, I'll hold off on any patching since it looks like
> you are working on this.
>
>> On Jan 28, 2018, at 6:49 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>>
>> On Sun, Jan 28, 2018 at 8:23 PM, Jim Jagielski <jim@jagunet.com> wrote:
>>>
>>>
>>>> On Jan 27, 2018, at 9:14 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>>>> But this change (r1822341) means that SHMs are not reused on graceful
>>>> restart, unless persisted.
>>>
>>> If that's the case, then that's a non-starter. Are you sure?
>>
>> Quite yes (tested actually), a new filename is generated at each
>> restart, so there is nothing to reuse in the list nor an SHM to attach
>> to. We could use the name instead of the filename to identify them in
>> the list, but anyway the key is to persist the list accross restarts
>> (ap_pglobal and so on...).
>>
>> I proposed a patch in bz (seems to work from my testing), not as light
>> as I would have hoped, but not completely insane either IMHO :)
>> WDYT?
>

Mime
View raw message