Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 72F60200D34 for ; Fri, 3 Nov 2017 07:46:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 71814160BFB; Fri, 3 Nov 2017 06:46:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B4ABB160BE9 for ; Fri, 3 Nov 2017 07:46:52 +0100 (CET) Received: (qmail 15851 invoked by uid 500); 3 Nov 2017 06:46:51 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 15841 invoked by uid 99); 3 Nov 2017 06:46:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2017 06:46:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E3825DCB6B for ; Fri, 3 Nov 2017 06:46:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.002 X-Spam-Level: **** X-Spam-Status: No, score=4.002 tagged_above=-999 required=6.31 tests=[BODY_URI_ONLY=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, KAM_LAZY_DOMAIN_SECURITY=1, RDNS_NONE=3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1V_uIt4uNk5M for ; Fri, 3 Nov 2017 06:46:50 +0000 (UTC) Received: from blaine.gmane.org (unknown [195.159.176.226]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0C95C5F4E5 for ; Fri, 3 Nov 2017 06:46:50 +0000 (UTC) Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eAVkU-00026p-TB for dev@httpd.apache.org; Fri, 03 Nov 2017 07:46:38 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: dev@httpd.apache.org From: Christophe JAILLET Subject: Re: Question about r1496711 which has been silently merged into 2.4.x branch Date: Fri, 3 Nov 2017 07:46:40 +0100 Lines: 35 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@blaine.gmane.org User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 In-Reply-To: Content-Language: fr archived-at: Fri, 03 Nov 2017 06:46:53 -0000 Le 02/11/2017 à 01:56, Eric Covener a écrit : > On Wed, Nov 1, 2017 at 7:58 PM, Christophe JAILLET > wrote: >> Hi, >> >> not sure on how to deal with the following issue. It has been found in a >> review of some trunk/CHANGES entries in order to remove some backported >> items. >> >> >> In commit r1772331, r1496711 has been silently merged into the 2.4.x branch. >> >> CHANGES for r149671 is: >> >> *) mod_file_cache: mod_file_cache should be able to serve files that >> haven't had a Content-Type set via e.g. mod_mime. [Eric Covener] >> >> >> Should this be: >> [1] reverted >> [2] added in the CHANGES of 2.4.x in the revision where it has been >> released >> [3] voted to keep track of it afterward >> [4] updated in the r1772331 commit message >> ? >> >> My guess is [2]+[4]+removal from trunk/CHANGES. >> > I think that's best as well. Thanks for catching it. > > I vaguely recall that I later found things that made mod_file_cache > almost certainly unused in practice. > Updated