httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marion & Christophe JAILLET <christophe.jail...@wanadoo.fr>
Subject Re: svn commit: r1813027 - /httpd/httpd/branches/2.4.x/STATUS
Date Wed, 01 Nov 2017 11:18:56 GMT
Same analysis here. The 2 declarations are the same.

CJ


Le 01/11/2017 à 11:02, Rainer Jung a écrit :
> Hi Bill,
>
> Am 31.10.2017 um 21:29 schrieb William A Rowe Jr:
>> On Mon, Oct 23, 2017 at 10:17 AM, <ylavic@apache.org> wrote:
>>> Author: ylavic
>>> Date: Mon Oct 23 15:17:02 2017
>>> New Revision: 1813027
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1813027&view=rev
>>> Log:
>>> Update comment according to patch version (v5).
>>>
>>> Modified:
>>>      httpd/httpd/branches/2.4.x/STATUS
>>>
>>> @@ -138,7 +137,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>>>        +1: ylavic,
>>>         wrowe: Suspect that this is an MMN Major bump, not minor 
>>> without some
>>>                additional detection/workaround of legacy 2.4 
>>> compiled modules.
>>> -     ylavic: Changed to v4 (+r1812193) which hopefully should 
>>> address compat
>>> +     ylavic: Changed to v5 (+r1812193) which hopefully should 
>>> address compat
>>>                issues, Bill?
>>
>> That seems to help with the config parser.
>>
>> This looks problematic; it is undoubtedly a binary ABI change to a
>> public interface.
>>
>> -APR_DECLARE_EXTERNAL_HOOK(proxy, PROXY, int, scheme_handler, 
>> (request_rec *r,
>> -                          proxy_worker *worker, proxy_server_conf
>> *conf, char *url,
>> -                          const char *proxyhost, apr_port_t
proxyport))
>> -APR_DECLARE_EXTERNAL_HOOK(proxy, PROXY, int, canon_handler, 
>> (request_rec *r,
>> -                          char *url))
>> [...]
>> +APR_DECLARE_EXTERNAL_HOOK(proxy, PROXY, int, scheme_handler,
>> +                          (request_rec *r, proxy_worker
*worker,
>> +                           proxy_server_conf *conf, char
*url,
>> +                           const char *proxyhost, apr_port_t

>> proxyport))
>> +APR_DECLARE_EXTERNAL_HOOK(proxy, PROXY, int, canon_handler,
>> +                          (request_rec *r, char *url))
>>
>
> This part you cited to me looks like just a reformat (position of line 
> breaks changed), but I couldn't spot a functional change there.
>
> Regards,
>
> Rainer
>


Mime
View raw message