httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From William A Rowe Jr <wr...@rowe-clan.net>
Subject Re: svn commit: r1808855 [2/2] - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS docs/manual/ docs/manual/mod/mod_proxy.xml modules/http2/ modules/proxy/mod_proxy.c modules/proxy/mod_proxy_balancer.c modules/proxy/proxy_util.c
Date Thu, 12 Oct 2017 17:42:30 GMT
On Sep 19, 2017 05:17, <jim@apache.org> wrote:


Modified: httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/
modules/proxy/mod_proxy.c?rev=1808855&r1=1808854&r2=1808855&view=diff
============================================================
==================
--- httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c (original)
+++ httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c Tue Sep 19
10:17:40 2017
@@ -103,7 +103,8 @@ static const char *set_worker_param(apr_
         /* Normalized load factor. Used with BalancerMember,
          * it is a number between 1 and 100.
          */
-        ival = atoi(val);
+        double fval = atof(val);
+        ival = fval * 100.0;
         if (ival < 1 || ival > 100)
             return "LoadFactor must be a number between 1..100";
         worker->s->lbfactor = ival;


As this patch was obviously never tested by a single reviewer, my
inclination is to revert this non-feature regression, in order to tag a
2.4.29 tomorrow a.m., Windows and OS/X 10.13 ready with the many small
fixes already committed. Then, let this feature be reintroduced when
working, with some testing, along with many other enhancements proposed
right now but all potentially disruptive, as a 2.4.30 to follow soon after
a .29 stability release.

Thoughts?

Mime
View raw message