Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EA45B200CE0 for ; Fri, 11 Aug 2017 01:18:33 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E899116C630; Thu, 10 Aug 2017 23:18:33 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3AC9F16C62F for ; Fri, 11 Aug 2017 01:18:33 +0200 (CEST) Received: (qmail 81574 invoked by uid 500); 10 Aug 2017 23:18:32 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 81564 invoked by uid 99); 10 Aug 2017 23:18:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Aug 2017 23:18:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 928D2C1933 for ; Thu, 10 Aug 2017 23:18:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.379 X-Spam-Level: ** X-Spam-Status: No, score=2.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id LbILB6biy6iN for ; Thu, 10 Aug 2017 23:18:29 +0000 (UTC) Received: from mail-it0-f51.google.com (mail-it0-f51.google.com [209.85.214.51]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 09D285F3CF for ; Thu, 10 Aug 2017 23:18:29 +0000 (UTC) Received: by mail-it0-f51.google.com with SMTP id 76so20204130ith.0 for ; Thu, 10 Aug 2017 16:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=1IVhstlkiZsOnZacNoiau37uvvRCyfVIk8w/qNubQLU=; b=qw4F9a0Rcmw5CZwn/qntgN5sdm5FY44WLBSqs8ZMfBApevEgA5aGo59kMvAaMZaknO qcVCf9Fj+2fCvVn6dx6kaYqcvrsjSze/P/0KU29U2QqFZ2DfdPCgEkHWK0+rNlLvuaVc ntim6ntjrQ2EiOtzGUtLk+jxbdTgxZ8Pf7JygqTUQoxG+M6GqWo5ocvVKMV5tLq/LaIc RYU1BO63nueffnTon0Vtice+/2T1E6K48WHs6Di2e2DqILFcCE6WrAkRMJFQ+Jemmg8/ OeWcV8ZQRs0pLkYvdKTfAALjst28hTLFfc9+B2Ne/gVSCakEer97g1BtAYSAeYZ3WZ9D 7Ovw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=1IVhstlkiZsOnZacNoiau37uvvRCyfVIk8w/qNubQLU=; b=JIigItSDAHL12rgH3GzPdb0f//0dX9IEI/9UJ9meyN81MZWh4+vsBrU9hA9FzIwrmp GISPkQ7+hBrNsFdtod+9azRO+9rQgtnZchImVz1PvJJC9N6b29Gbjr6pymhDrsC1Snb9 +PEjm1s8L7zg61upRAcC+RbN1L9W09omtQOx0qryJZ5Mh8HpTIZ/S2VpFVU9OCMD9cqS 0cfLy1p+PjaFR5A3LQSht2ilkm/w+TWDDnMdADj8yAy79mVQp1xhTP2g76y7Ga695adh R+OfvFIAeJ5u8tACSsQM4nOLlmN8Dc0DsFwoCETFltEC3q5DnFUBAXP3HiM2Whf6bmaE Oohw== X-Gm-Message-State: AHYfb5hwUVWt7QktPnLHsrQsuxp93OTN/21A7JhE+S63lp1s6bOJBAc0 KUwhR4JPe7/21W86CvSbIKe94aWRDw== X-Received: by 10.36.173.7 with SMTP id c7mr11369619itf.62.1502407107155; Thu, 10 Aug 2017 16:18:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.13.193 with HTTP; Thu, 10 Aug 2017 16:18:26 -0700 (PDT) In-Reply-To: <20170810135829.402CB3A010E@svn01-us-west.apache.org> References: <20170810135829.402CB3A010E@svn01-us-west.apache.org> From: Greg Stein Date: Thu, 10 Aug 2017 18:18:26 -0500 Message-ID: Subject: Re: svn commit: r1804671 - /httpd/httpd/trunk/modules/md/mod_md_config.c To: dev@httpd.apache.org Content-Type: multipart/alternative; boundary="94eb2c1fb8e4ee202b05566e698b" archived-at: Thu, 10 Aug 2017 23:18:34 -0000 --94eb2c1fb8e4ee202b05566e698b Content-Type: text/plain; charset="UTF-8" On Thu, Aug 10, 2017 at 8:58 AM, wrote: > Author: icing > Date: Thu Aug 10 13:58:26 2017 > New Revision: 1804671 > > URL: http://svn.apache.org/viewvc?rev=1804671&view=rev > Log: > fix for >... > +++ httpd/httpd/trunk/modules/md/mod_md_config.c Thu Aug 10 13:58:26 2017 > >... > @@ -215,7 +218,7 @@ static const char *md_config_sec_add_mem > const char *err; > int i; > > - if (NULL != (err = md_section_check(cmd))) { > + if (NULL != (err = md_section_check(cmd, " Seems you should be using a symbolic constant for the dozen occurrences of this string, in order to avoid typos. >... Cheers, -g --94eb2c1fb8e4ee202b05566e698b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On T= hu, Aug 10, 2017 at 8:58 AM, <icing@apache.org> wrote:
Author: icing
Date: Thu Aug 10 13:58:26 2017
New Revision: 1804671

URL: http://svn.apache.org/viewvc?rev= =3D1804671&view=3Drev
Log:
fix for <ManagedDomain sections with inner <If or other sections
<= /blockquote>
>...=C2=A0
+++ http= d/httpd/trunk/modules/md/mod_md_config.c Thu Aug 10 13:58:26 2017
<= /blockquote>
>...=C2=A0
@@ -215,= 7 +218,7 @@ static const char *md_config_sec_add_mem
=C2=A0 =C2=A0 =C2=A0const char *err;
=C2=A0 =C2=A0 =C2=A0int i;

-=C2=A0 =C2=A0 if (NULL !=3D (err =3D md_section_check(cmd))) {
+=C2=A0 =C2=A0 if (NULL !=3D (err =3D md_section_check(cmd, "<Manag= edDomain"))) {

Seems you should be= using a symbolic constant for the dozen occurrences of this string, in ord= er to avoid typos.

>...

Cheers,
-g

--94eb2c1fb8e4ee202b05566e698b--