httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@gmail.com>
Subject Re: svn commit: r1804671 - /httpd/httpd/trunk/modules/md/mod_md_config.c
Date Thu, 10 Aug 2017 23:18:26 GMT
On Thu, Aug 10, 2017 at 8:58 AM, <icing@apache.org> wrote:

> Author: icing
> Date: Thu Aug 10 13:58:26 2017
> New Revision: 1804671
>
> URL: http://svn.apache.org/viewvc?rev=1804671&view=rev
> Log:
> fix for <ManagedDomain sections with inner <If or other sections
>
>...

> +++ httpd/httpd/trunk/modules/md/mod_md_config.c Thu Aug 10 13:58:26 2017
>
>...

> @@ -215,7 +218,7 @@ static const char *md_config_sec_add_mem
>      const char *err;
>      int i;
>
> -    if (NULL != (err = md_section_check(cmd))) {
> +    if (NULL != (err = md_section_check(cmd, "<ManagedDomain"))) {
>

Seems you should be using a symbolic constant for the dozen occurrences of
this string, in order to avoid typos.

>...

Cheers,
-g

Mime
View raw message