Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: <e5736d12-569a-b995-3d33-b4daaa6d8778@gmail.com>
References: <20151006163053.95FFE3A0141@svn01-us-west.apache.org>
 <ca2be908-39ff-2e85-db80-505d74e45b84@gmail.com> <CAKQ1sVNxU9DTh+6Rh=u_X83V+_CuSdhWHqkniMDYYHhy=7Doog@mail.gmail.com>
 <80b43623-b6f5-88a2-f455-fedb6fff5b14@gmail.com> <CAKQ1sVP-czk=tss21FOdzCQKodsG3Nuo=vEutZTYh3uyHswoaA@mail.gmail.com>
 <CAKQ1sVN1uoeiN_qzH9Wyg3Ub-sT0f3qCZFr+f_22M1uUV_feaA@mail.gmail.com> <e5736d12-569a-b995-3d33-b4daaa6d8778@gmail.com>
From: Yann Ylavic <ylavic.dev@gmail.com>
Date: Wed, 26 Apr 2017 01:02:29 +0200
Message-ID: <CAKQ1sVMvp2QVSUp6enXWeUd2BznS-Vc8rxdq0_agXboNOb_-pw@mail.gmail.com>
Subject: Re: svn commit: r1707087 - /httpd/httpd/trunk/modules/debugging/mod_bucketeer.c
To: httpd-dev <dev@httpd.apache.org>
Content-Type: text/plain; charset=UTF-8
archived-at: Tue, 25 Apr 2017 23:02:35 -0000

Hi Jacob,

On Tue, Apr 25, 2017 at 11:58 PM, Jacob Champion <champion.p@gmail.com> wrote:
>
> Unfortunately the patch just moves the crash to another location. We can't
> call APR_BRIGADE_EMPTY() on a brigade that's pointing at junk. I think a
> bucket that cleans up the brigade it's a part of is just not a good idea. :)
> So moving to c->pool is an option for a quick fix, I suppose...
>
> ...but I'm more inclined to look at the whole EOR bucket situation --
> specifically eor_bucket_destroy() and its helpers. Why is the EOR bucket
> responsible for freeing the request's pool in the first place? It doesn't
> own the request. Surely we should be freeing the pool in the same code
> context in which we've allocated the pool?
>
> One of the comments in eor_bucket.c is "eor_bucket_destroy might be called
> at a point of time when the request pool had been already destroyed", which
> makes me incredibly suspicious of the whole thing. Finalizers are not a
> great place to put business logic.

Let me remind this a bit, it's been a long time :)
Will have a look at it tomorrow hopefully..


Regards,
Yann.