httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Ruggeri <DRugg...@primary.net>
Subject Re: svn commit: r1790170 - /httpd/httpd/branches/2.4.x/STATUS
Date Mon, 10 Apr 2017 23:31:48 GMT

On 4/5/2017 12:55 AM, Christophe JAILLET wrote:
> Hi,
>
> in 'remoteip_disable_networks', 'RemoteIPProxyProtocolDisableNetworks'
> should be updated to 'RemoteIPProxyProtocolExceptions' or
> cmd->cmd->name should used insteead.
> Fonction name (i.e. 'remoteip_disable_networks') could also be updated
> to better match de directive name.
>
> (sorry, I can't fix it myself, because of issues with my WMs :( )
>
> CJ
>
> Le 05/04/2017 à 03:16, druggeri@apache.org a écrit :
>> Author: druggeri
>> Date: Wed Apr  5 01:16:26 2017
>> New Revision: 1790170
>>
>> URL: http://svn.apache.org/viewvc?rev=1790170&view=rev
>> Log:
>> Update proposal with the latest trunk commit
>>
>> Modified:
>>      httpd/httpd/branches/2.4.x/STATUS
>>
>> Modified: httpd/httpd/branches/2.4.x/STATUS
>> URL:
>> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1790170&r1=1790169&r2=1790170&view=diff
>> ==============================================================================
>>
>> --- httpd/httpd/branches/2.4.x/STATUS (original)
>> +++ httpd/httpd/branches/2.4.x/STATUS Wed Apr  5 01:16:26 2017
>> @@ -168,6 +168,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>>                     http://svn.apache.org/r1781701 (rework optional
>> processing case)
>>                     http://svn.apache.org/r1788674 (final edge
>> cases/ignore slave conns)
>>                     http://svn.apache.org/r1789800 (remove optional
>> processing)
>> +                  http://svn.apache.org/r1790169 (rename "exception"
>> directive)
>>        2.4 convenience patch (includes CHANGES):
>>                    
>> http://people.apache.org/~druggeri/patches/RemoteIPProxyProtocol.2.4.x.patch
>>        +1: druggeri, jim
>>
>>
>>
>

You are correct - not sure how that escaped the
s/RemoteIPProxyProtocolDisableNetworks/RemoteIPProxyProtocolExceptions/g
operation. Thanks!

I've updated the backport proposal to include your note as well as the
2.4 convenience patch.


@wrowe - I think the updated proposal addresses the concerns around the
optional processing. Would love if you can spare a few cycles before the
upcoming 2.4.26 to review and offer your +1 or at least nyx the -.5 note
in case that's deterring others.

-- 
Daniel Ruggeri


Mime
View raw message