httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Eissing <stefan.eiss...@greenbytes.de>
Subject Re: svn commit: r1788981 - in /httpd/httpd/trunk: ./ modules/http2/
Date Wed, 29 Mar 2017 07:04:42 GMT
Added config check and feature reporting in r1789279. Thanks for the review!

> Am 27.03.2017 um 22:51 schrieb Jacob Champion <champion.p@gmail.com>:
> 
> On 03/27/2017 09:31 AM, icing@apache.org wrote:
>> @@ -500,7 +533,11 @@ h2_stream *h2_stream_create(int id, apr_
>> 
>>     h2_beam_create(&stream->output, pool, id, "output", H2_BEAM_OWNER_RECV,
0,
>>                    session->s->timeout);
>> -
>> +
>> +    stream->in_window_size =
>> +        nghttp2_session_get_stream_local_window_size(
>> +            stream->session->ngh2, stream->id);
>> +
> 
> The configure script doesn't look for the "new" get_stream_local_window_size() API, so
trying to build against an earlier libnghttp2 succeeds during configuration but fails at linktime.
Is there a good fallback to use, or should we update the version prerequisites for nghttp2?
> 
> --Jacob

Stefan Eissing

<green/>bytes GmbH
Hafenstrasse 16
48155 M√ľnster
www.greenbytes.de


Mime
View raw message