Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Mon, 20 Feb 2017 16:16:00 +0000
From: Joe Orton <jorton@redhat.com>
To: dev@httpd.apache.org
Subject: Re: [2.2 PATCH] fix HttpProtocolOptions (etc) merging
Message-ID: <20170220161600.GA21055@redhat.com>
Mail-Followup-To: dev@httpd.apache.org
References: <20170217093032.GA1137@redhat.com>
 <CACsi253pYgF8f4Orcq3Wa99fMW=n=Saw4HeqGWUWNBRmHikUyA@mail.gmail.com>
 <CALK=YjNN6i=VoBXh_moyBJkLRPBZTf3T-dfsTSJyeFMottrqPg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CALK=YjNN6i=VoBXh_moyBJkLRPBZTf3T-dfsTSJyeFMottrqPg@mail.gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Organization: Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul Argiry (US)
archived-at: Mon, 20 Feb 2017 16:17:12 -0000

On Fri, Feb 17, 2017 at 12:38:30PM -0500, Eric Covener wrote:
> +1
> 
> On Fri, Feb 17, 2017 at 12:37 PM, William A Rowe Jr <wrowe@rowe-clan.net> wrote:
> > Great catch; +1 to commit to 2.2.x and
> > http://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict/
> > branches.
> >
> > And thanks for adding the breadcrumb for the next sucker to miss this :-O

Thanks for the reviews.

2.2.x => http://svn.apache.org/viewvc?rev=1783440&view=rev
2.2.x-merge-strict => http://svn.apache.org/viewvc?rev=1783441&view=rev

FYI, since I've seen people thinking seriously about test suites, this 
kind of issue is impossible to test comprehensively with the current 
test framework. We really need to spin up httpd multiple times with 
different configurations, to test different combinations of global to 
vhost merges with default vs non-default options.

(If there is some way to do that with the current test suite, I'd be 
interested to hear anyway.)

Regads, Joe