httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Eissing <stefan.eiss...@greenbytes.de>
Subject Re: mod_http2 and Frequent wake-ups for mpm_event
Date Mon, 06 Feb 2017 15:03:19 GMT
I took Yann's v3 patch and changed a tiny bit in the h2. I just added a var declaration in
event.c without which it did not compile for me.

-Stefan

> Am 06.02.2017 um 15:41 schrieb Stefan Priebe - Profihost AG <s.priebe@profihost.ag>:
> 
> Hi,
> 
> so i should test the mpm event part from Yann + your http2 part?
> 
> Stefan
> 
> Am 06.02.2017 um 15:34 schrieb Stefan Eissing:
>> Yes, that was mixing the order. The attached v4 compiles and runs the h2 tests for
me without errors.
>> 
>> 
>> 
>> 
>> 
>>> Am 06.02.2017 um 14:43 schrieb Yann Ylavic <ylavic.dev@gmail.com>:
>>> 
>>> On Mon, Feb 6, 2017 at 2:31 PM, Stefan Eissing
>>> <stefan.eissing@greenbytes.de> wrote:
>>>> Currently running some tests. Have crashes on the original patch in my test
suite. Fixed one, hunting for the next...
>>> 
>>> I think it comes from my change that creates slave connections from
>>> master->pool (instead of mplx's), because now slave's pool is already
>>> destroyed when h2_mplx_release_and_join()->task_destroy()->h2_slave_destroy()
>>> is called (hence the crash).
>>> 
>>> I restored your original code in this new (attached) patch.
>>> 
>>> @s.priebe, would you test this one please?
>>> <ptrans_and_slaves_allocator-v3.patch>
>> 
>> Stefan Eissing
>> 
>> <green/>bytes GmbH
>> Hafenstrasse 16
>> 48155 Münster
>> www.greenbytes.de
>> 

Stefan Eissing

<green/>bytes GmbH
Hafenstrasse 16
48155 Münster
www.greenbytes.de


Mime
View raw message