Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8B443200BF6 for ; Tue, 10 Jan 2017 14:21:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 89DF6160B4B; Tue, 10 Jan 2017 13:21:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D4520160B3D for ; Tue, 10 Jan 2017 14:20:59 +0100 (CET) Received: (qmail 60358 invoked by uid 500); 10 Jan 2017 13:20:58 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 60348 invoked by uid 99); 10 Jan 2017 13:20:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jan 2017 13:20:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 19DEB1A0017 for ; Tue, 10 Jan 2017 13:20:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.379 X-Spam-Level: X-Spam-Status: No, score=0.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id V8kYzvlf3l0W for ; Tue, 10 Jan 2017 13:20:54 +0000 (UTC) Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 6D95E5F30F for ; Tue, 10 Jan 2017 13:20:53 +0000 (UTC) Received: by mail-oi0-f50.google.com with SMTP id u143so137364169oif.3 for ; Tue, 10 Jan 2017 05:20:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=aY/dykvMiF3evjQAzsKmaYr9RbgHsIb8XHz9YWeCQQw=; b=VRdS7OiPWtuIYUVzOLNkzJXy6gDCH6vwaUUPcKYZzbi3OoKZ8uQDu4GcrABbeoE44N 3qXXKriSxyIFGQTZqPVCSwBk1P7Ez6FvjvAeEvkPQCHBQPeG29M5yoRzhblWUHjTx8+f XhpQCOF4SHQF8b8CBpO3Gl51br0yRx15yGSHVg3eU5Uctlt3vDItx62eFVqvIaYg6o9B nkMToHpiOZfX0oXaWbk8Ek41OgIe51v5eBeWWa5H0wtfaTX0Dmz8bTtEUxw7EXufFthi SJXhYspSeDpQ09yrTRvPh8viqzQ7rudJsDjWIEqIeGJMCKouvWCwF6KAEEvSCA7k7An6 X/SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=aY/dykvMiF3evjQAzsKmaYr9RbgHsIb8XHz9YWeCQQw=; b=PVoPAxa/NdagBHPLGXaxPYqlQUIvS067JLT1hf8QKsFAAXCaq8eIvcaH8MkODubA3H jKvH7quiIHlN1M23lCuNwHsLn15bXOKuZNh5Vj5RtMlhX3BRSyp1VvRpHihJst/+lqaM EobC2eqKc5noy/GUBp0nF8WLEbgMwEysrJTQLOuWqXDRvl0oHoeZ7cZisksBN1Ix9KCP SiYey1dkad8/6Hmb5o7Y7Zd6uGT2PovLd+vWQunC3fkOcofjfF/H1eeZrsEOJNE+nKFa oaGzTXRNB4TsIKdM2mFIB1I57WPDq+HohzIl4VMNesSw2PfoXyyxq7UxQRL9fkEkLZIf 3QZQ== X-Gm-Message-State: AIkVDXJpr0dFIZGn1MdJe3EItO/m6VadZADwIzTnpjeW1U4Q9NAfn7iXj5DUSRP7kzt93L4iYm7Z6UhAUSFumg== X-Received: by 10.157.47.152 with SMTP id r24mr1391058otb.126.1484054451966; Tue, 10 Jan 2017 05:20:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.18.209 with HTTP; Tue, 10 Jan 2017 05:20:51 -0800 (PST) In-Reply-To: <03d992e9-e651-2402-4080-a227a2166a6c@apache.org> References: <20161228144055.B9B4A3A0315@svn01-us-west.apache.org> <03d992e9-e651-2402-4080-a227a2166a6c@apache.org> From: Eric Covener Date: Tue, 10 Jan 2017 08:20:51 -0500 Message-ID: Subject: Re: svn commit: r1776285 - /httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c To: Apache HTTP Server Development List Content-Type: text/plain; charset=UTF-8 archived-at: Tue, 10 Jan 2017 13:21:00 -0000 On Tue, Jan 10, 2017 at 4:59 AM, Ruediger Pluem wrote: > > > On 12/28/2016 03:40 PM, covener@apache.org wrote: >> Author: covener >> Date: Wed Dec 28 14:40:54 2016 >> New Revision: 1776285 >> >> URL: http://svn.apache.org/viewvc?rev=1776285&view=rev >> Log: >> improve a debug message >> >> >> Modified: >> httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c >> >> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c >> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c?rev=1776285&r1=1776284&r2=1776285&view=diff >> ============================================================================== >> --- httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c (original) >> +++ httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c Wed Dec 28 14:40:54 2016 >> @@ -467,7 +467,8 @@ static int proxy_wstunnel_handler(reques >> upgrade = apr_table_get(r->headers_in, "Upgrade"); >> if (!upgrade || ap_cstr_casecmp(upgrade, "WebSocket") != 0) { >> ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(02900) >> - "declining URL %s (not WebSocket)", url); >> + "declining URL %s (not WebSocket, Upgrade: header is %s)", >> + url, upgrade ? "missing" : upgrade); > > Shouldn't it be > > upgrade ? upgrade : "missing" yes thanks as always! flipped in 1778117