Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EC958200C00 for ; Wed, 18 Jan 2017 14:25:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E98E2160B44; Wed, 18 Jan 2017 13:25:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 18399160B3A for ; Wed, 18 Jan 2017 14:25:56 +0100 (CET) Received: (qmail 72544 invoked by uid 500); 18 Jan 2017 13:25:55 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 72534 invoked by uid 99); 18 Jan 2017 13:25:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2017 13:25:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7B6CE18066C for ; Wed, 18 Jan 2017 13:25:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.38 X-Spam-Level: ** X-Spam-Status: No, score=2.38 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id fzCGSXhamSxD for ; Wed, 18 Jan 2017 13:25:54 +0000 (UTC) Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 9C7175F47A for ; Wed, 18 Jan 2017 13:25:53 +0000 (UTC) Received: by mail-wm0-f52.google.com with SMTP id c206so24990546wme.0 for ; Wed, 18 Jan 2017 05:25:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=JY39I/8Sc2yV0ReNU32Cl7/WNVYa4/c+ypSi2U86+L8=; b=fMDeRHjW888c3o4xOgjWkp5yvE9OBVlWNm+Du06BLHMoqy3pCYgofJOQDnPuaz0+aV FRgC41BdEqDz7l+AR9Pfg9lYZ8XS4A9X/AuY5JAn7kYqnrYpf7ut7wkk/IfsWLA/PoNM s7Ny222qsR7ksYxKRVImc+qjEV57hLmia/wdEwvL6xxPxu42UrBvjxYOk2ojmbWVH78Q I3SWJk1KowDZ4q7YucgUfYUBuy2z9ne1hxR3vGutRFpnIRVp7v/9v45eX5KHspoFOah3 5PiGLpL41KNAE35dFd3I+t3hfXF3Gq23LmQ/nFADHB5Q+535X2dfijqdL2FoCc9l1j8Q 9g0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=JY39I/8Sc2yV0ReNU32Cl7/WNVYa4/c+ypSi2U86+L8=; b=NdOVOX2zU9cbN9PqS/YROZ/jo1plBGWgnJ07SS0KWXESLDEqsFTxUUBi+XTKQQ+FNc mO8RDsNtkOdYOiJiLtbxj+aRGB7dO+MY8pNo91w37ETmw34pXQMkWtV95kIcN/gjmDBq Km9JNlkMh4fTn2ZGqgos8P/nKsG1AtD6h2l1Q7kZ2aukDRXohCIGhn5Dcseb/4YYoEw5 rkjunJg0yLl/d+KlYEoL5MJ8TmWmqosp9eF/JIXy0CXYTPX5tr8EVWu7fyxRA+KLUkVr fV3W1krBd14zdL+qyY+8VWpyrN6edgnDSZ/lBS4qjaRpqCPEje0xtgMz8s4kSOinGMLl u9ZQ== X-Gm-Message-State: AIkVDXLvMWRsCEAIZDdjTEbkMLvu+QSoPro5MdAPPCuCKUI3Wtz1zkWpGyE9AIkjb+zBFWZ6l7eaTXkTS0dk4Q== X-Received: by 10.28.179.7 with SMTP id c7mr11524924wmf.128.1484745947325; Wed, 18 Jan 2017 05:25:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.25.198 with HTTP; Wed, 18 Jan 2017 05:25:46 -0800 (PST) In-Reply-To: References: <4592036.VMXMpTd4BY@k> <6BC2F18F-D161-4580-B92E-7B083D95F3F4@sharp.fm> From: Luca Toscano Date: Wed, 18 Jan 2017 14:25:46 +0100 Message-ID: Subject: Re: Async write completion broken in trunk? To: Apache HTTP Server Development List Content-Type: multipart/alternative; boundary=001a11452e4cc5aca005465e5acc archived-at: Wed, 18 Jan 2017 13:25:58 -0000 --001a11452e4cc5aca005465e5acc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2017-01-18 14:00 GMT+01:00 Jim Jagielski : > > > On Jan 18, 2017, at 7:50 AM, Graham Leggett wrote: > > > > On 17 Jan 2017, at 7:40 PM, Luca Toscano wrote= : > > > >> Since this email thread seems important, is there any update from > anybody working on it? It would be great to open a bugzilla task otherwis= e, > to track everything and make sure that we don't forget about it :) > > > > I looked at this a while back - I found that pipelining support is > causing the blocking. > > > > When we=E2=80=99re handling pipelined requests and we reach a limit, we= block. > What we should be doing instead is looping round back to WRITE_COMPLETION= , > waiting for permission to write again. This should be reasonably > straightforward to fix, but my financial year end is the end of this mont= h > so can=E2=80=99t look at this till February. > > > > I suspect pipelining support has been suppressed in v2.4.x event MPM, > and was at some point =E2=80=9Cfixed=E2=80=9D on trunk, bringing this pro= blem back. > > > > Somewhat on-topic but also off-topic as well, but it does seem > that event on trunk is getting much more fragile instead of more > stable. It seems to be picking up some kruft which is making > event on trunk a *worse* option than what's in 2.4, despite a deeper > async alignment. > > My 2c view on this is that mpm-event has been getting better during the last months, but the nature of the changes, together with the fact that we have not developed a good way to test regressions, causes long running debugging tasks. In the case of the wake-ups, we are basically testing a new big feature thanks to live traffic from Stefan Priebe (thanks again for the help btw!), meanwhile it would be really great to have some sort of test to fake traffic and spot problems (that would absolutely not substitute the invaluable user feedback of course). Luca --001a11452e4cc5aca005465e5acc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2017-01-18 14:00 GMT+01:00 Jim Jagielski <jim@jagunet.com>:

> On Jan 18, 2017, at 7:50 AM, Graham Leggett <minfrin@sharp.fm> wrote:
>
> On 17 Jan 2017, at 7:40 PM, Luca Toscano <toscano.luca@gmail.com> wrote: >
>> Since this email thread seems important, is there any update from = anybody working on it? It would be great to open a bugzilla task otherwise,= to track everything and make sure that we don't forget about it :)
>
> I looked at this a while back - I found that pipelining support is cau= sing the blocking.
>
> When we=E2=80=99re handling pipelined requests and we reach a limit, w= e block. What we should be doing instead is looping round back to WRITE_COM= PLETION, waiting for permission to write again. This should be reasonably s= traightforward to fix, but my financial year end is the end of this month s= o can=E2=80=99t look at this till February.
>
> I suspect pipelining support has been suppressed in v2.4.x event MPM, = and was at some point =E2=80=9Cfixed=E2=80=9D on trunk, bringing this probl= em back.
>

Somewhat on-topic but also off-topic as well, but it does seem
that event on trunk is getting much more fragile instead of more
stable. It seems to be picking up some kruft which is making
event on trunk a *worse* option than what's in 2.4, despite a deeper async alignment.


My 2c view on this = is that mpm-event has been getting better during the last months, but the n= ature of the changes, together with the fact that we have not developed a g= ood way to test regressions, causes long running debugging tasks. In the ca= se of the wake-ups, we are basically testing a new big feature thanks to li= ve traffic from Stefan Priebe (thanks again for the help btw!), meanwhile i= t would be really great to have some sort of test to fake traffic and spot = problems (that would absolutely not substitute the invaluable user feedback= of course).

Luca=C2=A0

--001a11452e4cc5aca005465e5acc--