Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
From: Stefan Eissing <stefan.eissing@greenbytes.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
Subject: Re: svn commit: r1779528 - /httpd/httpd/trunk/modules/http2/h2_mplx.c
Date: Thu, 19 Jan 2017 23:33:57 +0100
References: <20170119210919.5347A3A1E65@svn01-us-west.apache.org>
 <CAKQ1sVNtb+SdkvDf3wkh_jWqx0caC7fTT4DGVh+CMAyh1=tKUw@mail.gmail.com>
 <4675A940-3775-430F-9875-A97585D9F02A@greenbytes.de>
 <CAKQ1sVPZ+3E9epC-saZFLbNyj2J4eWrFfhT8ph4r0FnLQiukoA@mail.gmail.com>
 <CAKQ1sVNS7AOoOogih-J+wq22djWVW92b1eaXpUPmHu_505gNiw@mail.gmail.com>
To: dev@httpd.apache.org
In-Reply-To: <CAKQ1sVNS7AOoOogih-J+wq22djWVW92b1eaXpUPmHu_505gNiw@mail.gmail.com>
Message-Id: <C4A05783-9A99-47B7-9123-CA9877EE2435@greenbytes.de>
archived-at: Thu, 19 Jan 2017 22:34:37 -0000

Have to sleep over this. But I agree that this area needs some change.

> Am 19.01.2017 um 23:31 schrieb Yann Ylavic <ylavic.dev@gmail.com>:
>=20
> On Thu, Jan 19, 2017 at 10:58 PM, Yann Ylavic <ylavic.dev@gmail.com> =
wrote:
>> On Thu, Jan 19, 2017 at 10:41 PM, Stefan Eissing
>> <stefan.eissing@greenbytes.de> wrote:
>>>=20
>>> Would work. But then we could just never destroy this directly,
>>> because it will always disappear via the parent h2_session pool?
>>=20
>> Yes, we only need to cleanups things (or take actions) that are not
>> cleaned implicitely by the pool itself.
>=20
> Actually for the h2_session_cleanup() case, it seems that releasing
> (and joining) the mplx should happen before anything else in (or
> after) the cleanup, so you may not want to put
> h2_mplx_release_and_join() in an mplx->pool cleanup that'd execute
> after.
>=20
> But if that's not an issue, you could do that and simply
> session->mplx=3DNULL in the session cleanup.
>=20
> If that's an issue, you could also register h2_session_cleanup as a
> "normal" (i.e. not "pre_") cleanup, so that it exectutes after all
> subpools are destroyed...
>=20
> I just proposed the minimal patch...

Stefan Eissing

<green/>bytes GmbH
Hafenstrasse 16
48155 M=C3=BCnster
www.greenbytes.de