Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3CD92200BF0 for ; Fri, 30 Dec 2016 19:47:19 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3B7D8160B32; Fri, 30 Dec 2016 18:47:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 86F35160B19 for ; Fri, 30 Dec 2016 19:47:18 +0100 (CET) Received: (qmail 19833 invoked by uid 500); 30 Dec 2016 18:47:17 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 19824 invoked by uid 99); 30 Dec 2016 18:47:17 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Dec 2016 18:47:17 +0000 Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 2ED0B1A00A8 for ; Fri, 30 Dec 2016 18:47:17 +0000 (UTC) Received: by mail-wm0-f52.google.com with SMTP id a197so326811211wmd.0 for ; Fri, 30 Dec 2016 10:47:17 -0800 (PST) X-Gm-Message-State: AIkVDXJXsHqDPmi9fz1kd12kELqEuyS/kd8mLXrcHHjPFb4SYznzfnSB2S2gxh+xeY9x6CKjGVT5ivfKEPWUaA== X-Received: by 10.28.154.144 with SMTP id c138mr34792464wme.104.1483123635785; Fri, 30 Dec 2016 10:47:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.25.129 with HTTP; Fri, 30 Dec 2016 10:47:15 -0800 (PST) In-Reply-To: <20161230182005.B615D3A0617@svn01-us-west.apache.org> References: <20161230182005.B615D3A0617@svn01-us-west.apache.org> From: Luca Toscano Date: Fri, 30 Dec 2016 19:47:15 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r1776616 - in /httpd/httpd/trunk/docs/manual/mod: mod_remoteip.html.en mod_remoteip.xml.fr mod_remoteip.xml.meta To: Apache HTTP Server Development List Content-Type: multipart/alternative; boundary=001a114b1f6c781c280544e4a1b9 archived-at: Fri, 30 Dec 2016 18:47:19 -0000 --001a114b1f6c781c280544e4a1b9 Content-Type: text/plain; charset=UTF-8 Hi Daniel and Jim, I saw your comments in one of the last email thread about Daniel's new code change for mod_remoteip, and I have some questions for the doc about the naming of the new directive: 2016-12-30 19:20 GMT+01:00 : > Author: elukey > Date: Fri Dec 30 18:20:04 2016 > New Revision: 1776616 > > URL: http://svn.apache.org/viewvc?rev=1776616&view=rev > Log: > Documentation rebuild for mod_remoteip > > Modified: > httpd/httpd/trunk/docs/manual/mod/mod_remoteip.html.en > httpd/httpd/trunk/docs/manual/mod/mod_remoteip.xml.fr > httpd/httpd/trunk/docs/manual/mod/mod_remoteip.xml.meta > > + using the RemoteIPProxyProtocolEnable > +

id="RemoteIPProxyProtocol">RemoteIPProxyProtocol name="remoteipproxyprotocol" id="remoteipproxyprotocol">Directive

> > +Syntax:ProxyProtocol > On|Optional|Off In the above snippets I can see three different names: RemoteIPProxyProtocolEnable, RemoteIPProxyProtocol and ProxyProtocol. The new directive in the C code is called RemoteIPProxyProtocolEnable, but I can see new logs using also RemoteIPProxyProtocol (like "RemoteIPProxyProtocol: internal error: have data left over; "). I personally like a lot RemoteIPProxyProtocol (rather than RemoteIPProxyProtocolEnable that seems a bit heavy to read), but everything is fine as long as we use a single name, especially in the logs that admins will read :) I haven't checked the code in detail so I might say something completely irrelevant, just writing the first things that I noticed! Luca --001a114b1f6c781c280544e4a1b9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Daniel and Jim,

I saw your comments = in one of the last email thread about Daniel's new code change for mod_= remoteip, and I have some questions for the doc about the naming of the new= directive:
In the above snippets I can see three = different names: RemoteIPProxyProtocolEnable, RemoteIPProxyProtocol and Pro= xyProtocol. The new directive in the C code is called RemoteIPProxyProtocol= Enable, but I can see new logs using also RemoteIPProxyProtocol (like "= ;RemoteIPProxyProtocol: internal error: have data left over; ").=C2=A0=

<= div class=3D"gmail_extra">

--001a114b1f6c781c280544e4a1b9--