Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B4550200BEC for ; Thu, 15 Dec 2016 06:31:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B2CDD160B2E; Thu, 15 Dec 2016 05:31:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 86642160B19 for ; Thu, 15 Dec 2016 06:31:03 +0100 (CET) Received: (qmail 93830 invoked by uid 500); 15 Dec 2016 05:30:57 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 93816 invoked by uid 99); 15 Dec 2016 05:30:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Dec 2016 05:30:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D59AFC23B4 for ; Thu, 15 Dec 2016 05:30:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4 X-Spam-Level: **** X-Spam-Status: No, score=4 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, KAM_BADIPHTTP=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, WEIRD_PORT=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=rowe-clan-net.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Zar_oNx7feVs for ; Thu, 15 Dec 2016 05:30:54 +0000 (UTC) Received: from mail-io0-f177.google.com (mail-io0-f177.google.com [209.85.223.177]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id F1CD25F19B for ; Thu, 15 Dec 2016 05:30:53 +0000 (UTC) Received: by mail-io0-f177.google.com with SMTP id h30so60076748iod.2 for ; Wed, 14 Dec 2016 21:30:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowe-clan-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=1PVpySVV1N4UI4pfrMuVlD+if5w6UItLI6ip95NCDSM=; b=U4uwtsJi10lSzpq52ptdUkNnCmZ4Qa6qYJOyGTJ3qMwAdxfo/8iApxYKXEc/bFrDzv 0QNm2qHL8FA2A44QEEdWB13GDNeSfvu+5lagpRiuYwDJeIngWuSNTpPe8wLcwVzNrr2c tkQL9QKKBEw3/Ee1o+tqHC8pF24yBnzQWsOrECo41RRnAyh7unq9CFmb4hrxfB7nqm/y 3l+uzkH1e/F0Q+aetMb3t/tupXOAgJXAOaE5Y90ktkZmivrZjLNUBvnXdGIWYvmT1eN5 w3CFEGgzKOgl2AAwGZ5u9b8izgkqtwP2B5lLe40Dm4jFT71Jyfb7qu28xkRda6Q6Qz0i YFQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=1PVpySVV1N4UI4pfrMuVlD+if5w6UItLI6ip95NCDSM=; b=tNwW9Ks+OxMlrQ8EDetBQtQnJ2kGYgTZLFy4EOst5iqNg7wEzo72E4UsG1S+loV7ag jNcxET1Pn1vOnn50ejQ12TSrELVaWybsYt81oTfksMz0K8EaNVzuHHIYZgQz5tGNp0+K kl3+v+pmTaKxntzts9ME0k4sWbNVUOqlejxHnsXOWrjDTbvEBUGBgCja5x9eXXyyZEjI ohq/iER1PQoxMaVDmtGdh0AWzJfOSqKfCmfIELnFuQdZL4V1STv60ECCoVIxvPpzqcO4 hptAn2IuDxFXcuFpn0Ii0yYuB4jVAr4wH/ux1EevhC5Qdx3jMoMs4o40v7a3HTovTT/T Lg7g== X-Gm-Message-State: AKaTC02i3vzatAyzpk8o5P7iVQ4Ba437ylJlmu6Etaeg+pbJxgFR4GUzneSBtGI4NIuysNVRUQvOAIAo9g6QRgaS X-Received: by 10.107.158.4 with SMTP id h4mr763585ioe.43.1481779852010; Wed, 14 Dec 2016 21:30:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.34.197 with HTTP; Wed, 14 Dec 2016 21:30:51 -0800 (PST) In-Reply-To: <20161214085151.GA3597@redhat.com> References: <20161213132033.4A90F3A0335@svn01-us-west.apache.org> <51F1D67F-E20E-4DD4-85AA-DF9303BE8EEA@jaguNET.com> <20161214085151.GA3597@redhat.com> From: William A Rowe Jr Date: Wed, 14 Dec 2016 23:30:51 -0600 Message-ID: Subject: Re: svn commit: r1774010 - in /httpd/test/framework/trunk/t: conf/extra.conf.in modules/ext_filter.t To: httpd Content-Type: multipart/alternative; boundary=001a1140e9acb6feb10543abc16d archived-at: Thu, 15 Dec 2016 05:31:04 -0000 --001a1140e9acb6feb10543abc16d Content-Type: text/plain; charset=UTF-8 On Wed, Dec 14, 2016 at 2:51 AM, Joe Orton wrote: > On Tue, Dec 13, 2016 at 10:14:21AM -0500, Jim Jagielski wrote: > > > > > On Dec 13, 2016, at 8:33 AM, Jim Jagielski wrote: > > > > > > This fails on all systems that have sed in /usr/bin/sed > > > or someplace other than /bin :( > > > > > > > Hmmm... even w/ the change to /usr/bin/sed I'm getting > > test #1 failing: > > Ah, sorry about that & thanks for adjusting the config. > > I adjusted the test case to cope with a sed which adds a trailing > newline now, does that pass with OS X sed? I'm yet to work out why the > test cases passes in trunk and fails in 2.4, mod_ext_filter is the same > in both branches. > Seeing different issues on Fedora 24 under 2.x and 2.4 branches, neither seems entirely good, 2.4 is especially strange. On 2.x branch, Test #2 fails with a failed to create process. # testing : slow filter process # expected: 'foobar' # received: ' # # 500 Internal Server Error # #

Internal Server Error

#

The server encountered an internal error or # misconfiguration and was unable to complete # your request.

#

Please contact the server administrator at # you@example.com to inform them of the time this error occurred, # and the actions you performed just before this error.

#

More information about this error may be available # in the server error log.

# ' not ok 2 [Thu Dec 15 05:07:20.945238 2016] [example_hooks:notice] [pid 19326:tid 139620847179520] AH03297: x_create_connection() [Thu Dec 15 05:07:20.945327 2016] [example_hooks:notice] [pid 19326:tid 139620847179520] AH03297: x_create_request() [Thu Dec 15 05:07:20.945573 2016] [authz_core:debug] [pid 19326:tid 139620847179520] mod_authz_core.c(834): [client 127.0.0.1:49182] AH01628: authorization result: granted (no directives) [Thu Dec 15 05:07:20.945603 2016] [charset_lite:debug] [pid 19326:tid 139620847179520] mod_charset_lite.c(216): [client 127.0.0.1:49182] AH01448: incomplete configuration: src unspecified, dst unspecified [Thu Dec 15 05:07:20.945742 2016] [dialup:notice] [pid 19326:tid 139620847179520] (70023)This function has not been implemented on this platform: [client 127.0.0.1:49182] AH02637: dialup: MPM doesn't support suspending [Thu Dec 15 05:07:20.981454 2016] [optional_hook_import:error] [pid 19326:tid 139620847179520] AH01866: Optional hook test said: GET /index.html HTTP/1.1 [Thu Dec 15 05:07:20.981473 2016] [optional_fn_export:error] [pid 19326:tid 139620847179520] AH01871: Optional function test said: GET /index.html HTTP/1.1 [Thu Dec 15 05:07:21.560737 2016] [example_hooks:notice] [pid 19326:tid 139620838786816] AH03297: x_create_connection() [Thu Dec 15 05:07:21.560806 2016] [example_hooks:notice] [pid 19326:tid 139620838786816] AH03297: x_create_request() [Thu Dec 15 05:07:21.560950 2016] [authz_core:debug] [pid 19326:tid 139620838786816] mod_authz_core.c(834): [client 127.0.0.1:49186] AH01628: authorization result: granted (no directives) [Thu Dec 15 05:07:21.560967 2016] [charset_lite:debug] [pid 19326:tid 139620838786816] mod_charset_lite.c(216): [client 127.0.0.1:49186] AH01448: incomplete configuration: src unspecified, dst unspecified [Thu Dec 15 05:07:21.561006 2016] [dialup:notice] [pid 19326:tid 139620838786816] (70023)This function has not been implemented on this platform: [client 127.0.0.1:49186] AH02637: dialup: MPM doesn't support suspending [Thu Dec 15 05:07:21.572188 2016] [optional_hook_import:error] [pid 19326:tid 139620838786816] AH01866: Optional hook test said: GET /apache/extfilter/out-foo/foobar.html HTTP/1.1 [Thu Dec 15 05:07:21.572199 2016] [optional_fn_export:error] [pid 19326:tid 139620838786816] AH01871: Optional function test said: GET /apache/extfilter/out-foo/foobar.html HTTP/1.1 [Thu Dec 15 05:07:21.572237 2016] [ext_filter:error] [pid 19326:tid 139620838786816] (9)Bad file descriptor: [client 127.0.0.1:49186] AH01466: apr_file_read(child output), len 18446744073709551615 [Thu Dec 15 05:07:21.572251 2016] [ext_filter:error] [pid 19326:tid 139620838786816] (9)Bad file descriptor: [client 127.0.0.1:49186] AH01468: ef_unified_filter() failed [Thu Dec 15 05:07:21.572267 2016] [example_hooks:notice] [pid 19326:tid 139620838786816] AH03297: x_create_request() [Thu Dec 15 05:07:21.578555 2016] [authz_core:debug] [pid 19326:tid 139620838786816] mod_authz_core.c(834): [client 127.0.0.1:49186] AH01628: authorization result: granted (no directives) [Thu Dec 15 05:07:21.578578 2016] [charset_lite:debug] [pid 19326:tid 139620838786816] mod_charset_lite.c(216): [client 127.0.0.1:49186] AH01448: incomplete configuration: src unspecified, dst unspecified [Thu Dec 15 05:07:21.578616 2016] [dialup:notice] [pid 19326:tid 139620838786816] (70023)This function has not been implemented on this platform: [client 127.0.0.1:49186] AH02637: dialup: MPM doesn't support suspending [Thu Dec 15 05:07:21.578683 2016] [ext_filter:error] [pid 19326:tid 139620838786816] (2)No such file or directory: [client 127.0.0.1:49186] AH01458: couldn't create child process to run `/home/wrowe/dev/test/test2x-apr20-ossl110/t/htdocs/modules/ext_filter/ sleepycat.pl' [Thu Dec 15 05:07:21.578690 2016] [ext_filter:error] [pid 19326:tid 139620838786816] (2)No such file or directory: [client 127.0.0.1:49186] AH01467: can't initialise output filter sleepy-cat-out: aborting [Thu Dec 15 05:07:21.578801 2016] [optional_hook_import:error] [pid 19326:tid 139620838786816] AH01866: Optional hook test said: GET /apache/extfilter/out-slow/foobar.html HTTP/1.1 [Thu Dec 15 05:07:21.578806 2016] [optional_fn_export:error] [pid 19326:tid 139620838786816] AH01871: Optional function test said: GET /apache/extfilter/out-slow/foobar.html HTTP/1.1 ossl110/t/htdocs/modules/ext_filter/sleepycat.pl' ... I presumed maybe a missing perl cpan component, perhaps it is... On 2.4 branch, everything seems to go sideways; t/modules/ext_filter.t .............. 1/24 # Failed test 2 in t/modules/ext_filter.t at line 26 # Failed test 5 in t/modules/ext_filter.t at line 36 # Failed test 6 in t/modules/ext_filter.t at line 37 # Failed test 7 in t/modules/ext_filter.t at line 36 fail #2 # Failed test 8 in t/modules/ext_filter.t at line 37 fail #2 # Failed test 9 in t/modules/ext_filter.t at line 36 fail #3 # Failed test 10 in t/modules/ext_filter.t at line 37 fail #3 # Failed test 11 in t/modules/ext_filter.t at line 36 fail #4 # Failed test 12 in t/modules/ext_filter.t at line 37 fail #4 # Failed test 13 in t/modules/ext_filter.t at line 36 fail #5 # Failed test 14 in t/modules/ext_filter.t at line 37 fail #5 # Failed test 15 in t/modules/ext_filter.t at line 36 fail #6 # Failed test 16 in t/modules/ext_filter.t at line 37 fail #6 # Failed test 17 in t/modules/ext_filter.t at line 36 fail #7 # Failed test 18 in t/modules/ext_filter.t at line 37 fail #7 # Failed test 19 in t/modules/ext_filter.t at line 36 fail #8 # Failed test 20 in t/modules/ext_filter.t at line 37 fail #8 # Failed test 21 in t/modules/ext_filter.t at line 36 fail #9 # Failed test 22 in t/modules/ext_filter.t at line 37 fail #9 # Failed test 23 in t/modules/ext_filter.t at line 36 fail #10 # Failed test 24 in t/modules/ext_filter.t at line 37 fail #10 t/modules/ext_filter.t .............. Failed 21/24 subtests I don't see anything else wrong on 2.4 branch except for t/modules/rewrite.t ................. 1/34 # Failed test 34 in t/modules/rewrite.t at line 120 t/modules/rewrite.t ................. Failed 1/34 subtests (1 TODO test unexpectedly succeeded) But I have not yet caught up with the latest commits to rewrite. Thinking that on 2.4 branch, a poorly performing retest against 2.4.23 is all that is needed to proceed to release, and then return to address later as not-a-regression. --001a1140e9acb6feb10543abc16d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On W= ed, Dec 14, 2016 at 2:51 AM, Joe Orton <jorton@redhat.com> w= rote:
On Tue, Dec 13, 2016 at 10:14:21AM -0500= , Jim Jagielski wrote:
>
> > On Dec 13, 2016, at 8:33 AM, Jim Jagielski <jim@jaguNET.com>= ; wrote:
> >
> > This fails on all systems that have sed in /usr/bin/sed
> > or someplace other than /bin=C2=A0 :(
> >
>
> Hmmm... even w/ the change to /usr/bin/sed I'm getting
> test #1 failing:

Ah, sorry about that & thanks for adjusting the config.

I adjusted the test case to cope with a sed which adds a trailing
newline now, does that pass with OS X sed?=C2=A0 I'm yet to work out wh= y the
test cases passes in trunk and fails in 2.4, mod_ext_filter is the same
in both branches.
=C2=A0
Seeing different is= sues on Fedora 24 under 2.x and 2.4 branches, neither
seems entir= ely good, 2.4 is especially strange.

On 2.x branch= , Test #2 fails with a failed to create process.

<= div># testing : slow filter process
# expected: 'foobar'<= /div>
# received: '<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML= 2.0//EN">
# <html><head>
# <tit= le>500 Internal Server Error</title>
# </head><= body>
# <h1>Internal Server Error</h1>
#= <p>The server encountered an internal error or
# misconfig= uration and was unable to complete
# your request.</p>
# <p>Please contact the server administrator at
# =C2= =A0you@example.com to inform them of= the time this error occurred,
# =C2=A0and the actions you perfor= med just before this error.</p>
# <p>More information= about this error may be available
# in the server error log.<= /p>
# </body></html>'
not ok 2
=

[Thu Dec 15 05:07:20.945238 2016] [example_h= ooks:notice] [pid 19326:tid 139620847179520] AH03297: x_create_connection()=
[Thu Dec 15 05:07:20.945327 2016] [example_hooks:notice] [pid 19= 326:tid 139620847179520] AH03297: x_create_request()
[Thu Dec 15 = 05:07:20.945573 2016] [authz_core:debug] [pid 19326:tid 139620847179520] mo= d_authz_core.c(834): [client 127.0.0.1:4= 9182] AH01628: authorization result: granted (no directives)
= [Thu Dec 15 05:07:20.945603 2016] [charset_lite:debug] [pid 19326:tid 13962= 0847179520] mod_charset_lite.c(216): [client 127.0.0.1:49182] AH01448: incomplete configuration: src unspecifie= d, dst unspecified
[Thu Dec 15 05:07:20.945742 2016] [dialup:noti= ce] [pid 19326:tid 139620847179520] (70023)This function has not been imple= mented on this platform: [client 127.0.0= .1:49182] AH02637: dialup: MPM doesn't support suspending
[Thu Dec 15 05:07:20.981454 2016] [optional_hook_import:error] [pid 19326:= tid 139620847179520] AH01866: Optional hook test said: GET /index.html HTTP= /1.1
[Thu Dec 15 05:07:20.981473 2016] [optional_fn_export:error]= [pid 19326:tid 139620847179520] AH01871: Optional function test said: GET = /index.html HTTP/1.1
[Thu Dec 15 05:07:21.560737 2016] [example_h= ooks:notice] [pid 19326:tid 139620838786816] AH03297: x_create_connection()=
[Thu Dec 15 05:07:21.560806 2016] [example_hooks:noti= ce] [pid 19326:tid 139620838786816] AH03297: x_create_request()
[= Thu Dec 15 05:07:21.560950 2016] [authz_core:debug] [pid 19326:tid 13962083= 8786816] mod_authz_core.c(834): [client = 127.0.0.1:49186] AH01628: authorization result: granted (no directives)=
[Thu Dec 15 05:07:21.560967 2016] [charset_lite:debug] [pid 1932= 6:tid 139620838786816] mod_charset_lite.c(216): [client 127.0.0.1:49186] AH01448: incomplete configuration: src= unspecified, dst unspecified
[Thu Dec 15 05:07:21.561006 2016] [= dialup:notice] [pid 19326:tid 139620838786816] (70023)This function has not= been implemented on this platform: [client 127.0.0.1:49186] AH02637: dialup: MPM doesn't support suspendin= g
[Thu Dec 15 05:07:21.572188 2016] [optional_hook_import:error] = [pid 19326:tid 139620838786816] AH01866: Optional hook test said: GET /apac= he/extfilter/out-foo/foobar.html HTTP/1.1
[Thu Dec 15 05:07:21.57= 2199 2016] [optional_fn_export:error] [pid 19326:tid 139620838786816] AH018= 71: Optional function test said: GET /apache/extfilter/out-foo/foobar.html = HTTP/1.1
[Thu Dec 15 05:07:21.572237 2016] [ext_filter:erro= r] [pid 19326:tid 139620838786816] (9)Bad file descriptor: [client 127.0.0.1:49186] AH01466: apr_file_read(chi= ld output), len 18446744073709551615
[Thu Dec 15 05:07:21.572251 = 2016] [ext_filter:error] [pid 19326:tid 139620838786816] (9)Bad file descri= ptor: [client 127.0.0.1:49186] AH014= 68: ef_unified_filter() failed
[Thu Dec 15 05:07:21.572267 2016] = [example_hooks:notice] [pid 19326:tid 139620838786816] AH03297: x_create_re= quest()
[Thu Dec 15 05:07:21.578555 2016] [authz_core:debug] [pid= 19326:tid 139620838786816] mod_authz_core.c(834): [client 127.0.0.1:49186] AH01628: authorization result: gran= ted (no directives)
[Thu Dec 15 05:07:21.578578 2016] [charset_li= te:debug] [pid 19326:tid 139620838786816] mod_charset_lite.c(216): [client = 127.0.0.1:49186] AH01448: incomplete= configuration: src unspecified, dst unspecified
[Thu Dec 15 05:0= 7:21.578616 2016] [dialup:notice] [pid 19326:tid 139620838786816] (70023)Th= is function has not been implemented on this platform: [client 127.0.0.1:49186] AH02637: dialup: MPM doesn'= t support suspending
[Thu Dec 15 05:07:21.578683 2016] [ext_filte= r:error] [pid 19326:tid 139620838786816] (2)No such file or directory: [cli= ent 127.0.0.1:49186] AH01458: couldn= 't create child process to run `/home/wrowe/dev/test/test2x-apr20-ossl1= 10/t/htdocs/modules/ext_filter/sleepycat.pl= '
[Thu Dec 15 05:07:21.578690 2016] [ext_filter:error] [p= id 19326:tid 139620838786816] (2)No such file or directory: [client 127.0.0.1:49186] AH01467: can't initial= ise output filter sleepy-cat-out: aborting
[Thu Dec 15 05:07:21.5= 78801 2016] [optional_hook_import:error] [pid 19326:tid 139620838786816] AH= 01866: Optional hook test said: GET /apache/extfilter/out-slow/foobar.html = HTTP/1.1
[Thu Dec 15 05:07:21.578806 2016] [optional_fn_export:er= ror] [pid 19326:tid 139620838786816] AH01871: Optional function test said: = GET /apache/extfilter/out-slow/foobar.html HTTP/1.1
ossl110/t/htd= ocs/modules/ext_filter/sleepycat.pl'= ;
...

I presumed maybe a missing perl cp= an component, perhaps it is...

On 2.4 branch, ever= ything seems to go sideways;

t/modules/ext_fi= lter.t .............. 1/24=C2=A0
# Failed test 2 in t/modules/ext= _filter.t at line 26
# Failed test 5 in t/modules/ext_filter.t at= line 36
# Failed test 6 in t/modules/ext_filter.t at line 37
# Failed test 7 in t/modules/ext_filter.t at line 36 fail #2
# Failed test 8 in t/modules/ext_filter.t at line 37 fail #2
#= Failed test 9 in t/modules/ext_filter.t at line 36 fail #3
# Fai= led test 10 in t/modules/ext_filter.t at line 37 fail #3
# Failed= test 11 in t/modules/ext_filter.t at line 36 fail #4
# Failed te= st 12 in t/modules/ext_filter.t at line 37 fail #4
# Failed test = 13 in t/modules/ext_filter.t at line 36 fail #5
# Failed test 14 = in t/modules/ext_filter.t at line 37 fail #5
# Failed test 15 in = t/modules/ext_filter.t at line 36 fail #6
# Failed test 16 in t/m= odules/ext_filter.t at line 37 fail #6
# Failed test 17 in t/modu= les/ext_filter.t at line 36 fail #7
# Failed test 18 in t/modules= /ext_filter.t at line 37 fail #7
# Failed test 19 in t/modules/ex= t_filter.t at line 36 fail #8
# Failed test 20 in t/modules/ext_f= ilter.t at line 37 fail #8
# Failed test 21 in t/modules/ext_filt= er.t at line 36 fail #9
# Failed test 22 in t/modules/ext_filter.= t at line 37 fail #9
# Failed test 23 in t/modules/ext_filter.t a= t line 36 fail #10
# Failed test 24 in t/modules/ext_filter.t at = line 37 fail #10
t/modules/ext_filter.t .............. Failed 21/= 24 subtests=C2=A0

I don't see anything e= lse wrong on 2.4 branch except for

t/modules/= rewrite.t ................. 1/34 # Failed test 34 in t/modules/rewrite.t at= line 120
t/modules/rewrite.t ................. Failed 1/34 subte= sts=C2=A0
(1 TODO test unexpectedly succeeded)

But I have not yet caught up with the latest commits to rewrite.

Thinking that on 2.4 branch, a poorly performing re= test against 2.4.23=C2=A0
is all that is needed to proceed to rel= ease, and then return to address=C2=A0
later as not-a-regression.=


--001a1140e9acb6feb10543abc16d--