httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1773761 - /httpd/httpd/trunk/modules/http/http_filters.c
Date Mon, 12 Dec 2016 19:45:37 GMT
On Mon, Dec 12, 2016 at 7:17 PM, Jacob Champion <champion.p@gmail.com> wrote:
> On 12/12/2016 08:18 AM, Yann Ylavic wrote:
>>
>> On Mon, Dec 12, 2016 at 3:32 PM, Eric Covener <covener@gmail.com> wrote:
>>>
>>> On Mon, Dec 12, 2016 at 6:25 AM, Yann Ylavic <ylavic.dev@gmail.com>
>>> wrote:
>>>>
>>>> Tested with "Header set 'X-Bad' '<something with CR>'" with no redirect
>>>> loop.
>>>
>>>
>>> w/ 'Header always set...' this still repeats
>>
>>
>> Right, with r1773812 it looks good.
>
>
> Even with r1773812, I'm still getting recursion with the `Header always set`
> case. ap_is_initial_req() is returning true during the ap_die() response.

The issue was that ap_die() calls ap_send_error_response() and not
ap_internal_redirect() when no ErrorDocument is configured (I was
blinded by my ErrorDocument test...).

I think it's addressed in r1773861 and r1773862, thanks all for testing.

Mime
View raw message