httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From William A Rowe Jr <wr...@rowe-clan.net>
Subject Re: svn commit: r1773761 - /httpd/httpd/trunk/modules/http/http_filters.c
Date Mon, 12 Dec 2016 18:38:03 GMT
On Mon, Dec 12, 2016 at 10:18 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:

> On Mon, Dec 12, 2016 at 3:32 PM, Eric Covener <covener@gmail.com> wrote:
> > On Mon, Dec 12, 2016 at 6:25 AM, Yann Ylavic <ylavic.dev@gmail.com>
> wrote:
> >> Tested with "Header set 'X-Bad' '<something with CR>'" with no redirect
> loop.
> >
> > w/ 'Header always set...' this still repeats
>
> Right, with r1773812 it looks good.
> We'd only recurse if not in internal redirect already, otherwise fall
> through with:
>     HTTP/1.1 500 Internal Server Error
>     Date: Mon, 12 Dec 2016 16:11:59 GMT
>     Server: Apache/2.5.0-dev (Unix) OpenSSL/1.0.2g
>     Content-Length: 0
>     Connection: close
>
> WDYT?
>

Looks like the right approach, tweaking the test framework to exercise
this solution. Thx!

Mime
View raw message