Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: <CACsi250iENm5hroyiiuDUWQ2qSWv4qUb1tOT1gJBBL-Rkr=Law@mail.gmail.com>
References: <CACsi250iENm5hroyiiuDUWQ2qSWv4qUb1tOT1gJBBL-Rkr=Law@mail.gmail.com>
From: William A Rowe Jr <wrowe@rowe-clan.net>
Date: Mon, 28 Nov 2016 13:40:36 -0600
Message-ID: <CACsi253fasF+Xnc-8cm9Q1yU__HNPkOeiWWmT2wMrweEbLvE6g@mail.gmail.com>
Subject: Re: Quieting warnings?
To: httpd <dev@httpd.apache.org>
Content-Type: multipart/alternative; boundary=001a11c02c76552a38054261a5d5
archived-at: Mon, 28 Nov 2016 19:40:53 -0000

--001a11c02c76552a38054261a5d5
Content-Type: text/plain; charset=UTF-8

  *) Fix warnings with new compilers, warnings treated as error
     in maintainer-mode, standard c-89 is enforced
     trunk patch: http://svn.apache.org/r1702948
                  http://svn.apache.org/r1759415
     2.4.x patch:
http://home.apache.org/~ylavic/patches/httpd-2.4.x-r1702948_and_co.patch
     +1: ylavic, jorton,
     jchampion: r1702948 doesn't quite work as advertised. -Werror is never
                added to CFLAGS because when combined with
-Wstrict-prototypes,
                the AC_LANG_PROGRAM won't compile (it uses a bare main()).
     ylavic: Maybe the -Werror case could be handled later, for now this
series
             avoids a lot of "warning: 'aplog_module_index' defined but not
             used [-Wunused-const-variable=]" thanks to AP_MAYBE_UNUSED.
     jchampion: Fine by me. I just think the dead code should be removed
from
                the backport in the meantime, so people don't have a false
sense
                of security.

I usually just read on beyond patches that are 'under discussion'.
STATUS isn't a good bidirectional communications mechanism.

jchampion, did you have a proposed alternative since you felt
strongly about this issue?

Cheers,

Bill

On Mon, Nov 28, 2016 at 1:37 PM, William A Rowe Jr <wrowe@rowe-clan.net>
wrote:

> Typical of a long batch of error noise on 2.4 HEAD (with the
> http strict merge patch applied) in --enable-maintainer-mode...
>
> In file included from /home/wrowe/dev/httpd-2.4/modules/mappers/mod_vhost_
> alias.c:45:0:
> /home/wrowe/dev/httpd-2.4/include/http_config.h:427:24: warning:
> 'aplog_module_index' defined but not used [-Wunused-const-variable=]
>      static int * const aplog_module_index = &(foo##_module.module_index)
>                         ^
> /home/wrowe/dev/httpd-2.4/include/http_config.h:437:5: note: in expansion
> of macro 'APLOG_USE_MODULE'
>      APLOG_USE_MODULE(foo);                         \
>      ^~~~~~~~~~~~~~~~
> /home/wrowe/dev/httpd-2.4/modules/mappers/mod_vhost_alias.c:447:1: note:
> in expansion of macro 'AP_DECLARE_MODULE'
>  AP_DECLARE_MODULE(vhost_alias) =
>  ^~~~~~~~~~~~~~~~~
>
> Has anyone investigated far enough for us to pacify gcc?
>

--001a11c02c76552a38054261a5d5
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>=C2=A0 *) Fix warnings with new compilers, warnings t=
reated as error</div><div>=C2=A0 =C2=A0 =C2=A0in maintainer-mode, standard =
c-89 is enforced</div><div>=C2=A0 =C2=A0 =C2=A0trunk patch: <a href=3D"http=
://svn.apache.org/r1702948">http://svn.apache.org/r1702948</a></div><div>=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <a href=3D"h=
ttp://svn.apache.org/r1759415">http://svn.apache.org/r1759415</a></div><div=
>=C2=A0 =C2=A0 =C2=A02.4.x patch: <a href=3D"http://home.apache.org/~ylavic=
/patches/httpd-2.4.x-r1702948_and_co.patch">http://home.apache.org/~ylavic/=
patches/httpd-2.4.x-r1702948_and_co.patch</a></div><div>=C2=A0 =C2=A0 =C2=
=A0+1: ylavic, jorton,</div><div>=C2=A0 =C2=A0 =C2=A0jchampion: r1702948 do=
esn&#39;t quite work as advertised. -Werror is never</div><div>=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 added to CFLAGS because when =
combined with -Wstrict-prototypes,</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 the AC_LANG_PROGRAM won&#39;t compile (it uses =
a bare main()).</div><div>=C2=A0 =C2=A0 =C2=A0ylavic: Maybe the -Werror cas=
e could be handled later, for now this series</div><div>=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0avoids a lot of &quot;warning: &#39;aplog_mo=
dule_index&#39; defined but not</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0used [-Wunused-const-variable=3D]&quot; thanks to AP_MAYBE=
_UNUSED.</div><div>=C2=A0 =C2=A0 =C2=A0jchampion: Fine by me. I just think =
the dead code should be removed from</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 the backport in the meantime, so people don&#39=
;t have a false sense</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 of security.</div><div><br></div><div>I usually just read on =
beyond patches that are &#39;under discussion&#39;.=C2=A0</div><div>STATUS =
isn&#39;t a good bidirectional communications mechanism.</div><div><br></di=
v><div>jchampion, did you have a proposed alternative since you felt</div><=
div>strongly about this issue?</div><div><br></div><div>Cheers,</div><div><=
br></div><div>Bill</div></div><div class=3D"gmail_extra"><br><div class=3D"=
gmail_quote">On Mon, Nov 28, 2016 at 1:37 PM, William A Rowe Jr <span dir=
=3D"ltr">&lt;<a href=3D"mailto:wrowe@rowe-clan.net" target=3D"_blank">wrowe=
@rowe-clan.net</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div=
 dir=3D"ltr"><div>Typical of a long batch of error noise on 2.4 HEAD (with =
the</div><div>http strict merge patch applied) in --enable-maintainer-mode.=
..</div><div><br></div><div>In file included from /home/wrowe/dev/httpd-2.4=
/<wbr>modules/mappers/mod_vhost_<wbr>alias.c:45:0:</div><div>/home/wrowe/de=
v/httpd-2.4/<wbr>include/http_config.h:427:24: warning: &#39;aplog_module_i=
ndex&#39; defined but not used [-Wunused-const-variable=3D]</div><div>=C2=
=A0 =C2=A0 =C2=A0static int * const aplog_module_index =3D &amp;(foo##_modu=
le.module_index)</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^</div><div>/home/wrowe/dev/httpd-2.4/<=
wbr>include/http_config.h:437:5: note: in expansion of macro &#39;APLOG_USE=
_MODULE&#39;</div><div>=C2=A0 =C2=A0 =C2=A0APLOG_USE_MODULE(foo); =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 \</div><div>=C2=A0 =C2=A0 =C2=A0^~~~~~~~~~~~~~~~</div><div>/home/wrowe/=
dev/httpd-2.4/<wbr>modules/mappers/mod_vhost_<wbr>alias.c:447:1: note: in e=
xpansion of macro &#39;AP_DECLARE_MODULE&#39;</div><div>=C2=A0AP_DECLARE_MO=
DULE(vhost_<wbr>alias) =3D</div><div>=C2=A0^~~~~~~~~~~~~~~~~</div><div><br>=
</div><div>Has anyone investigated far enough for us to pacify gcc?</div></=
div>
</blockquote></div><br></div>

--001a11c02c76552a38054261a5d5--