Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: <CACsi251tM47pGdqBhx+nFB_oXLYW+tQAgibYKRUo+hQ5FeJiNg@mail.gmail.com>
References: <20161104190406.326263A0222@svn01-us-west.apache.org>
 <CACsi252L13bu8hWgKkn2ncBnxdZUdttqJRZ0ExgkHiaznkUjMA@mail.gmail.com>
 <CAKQ1sVMu7TSLjdovtbpYe4m1k=zPLG=aN0_Rj7CH71rB2vbPjQ@mail.gmail.com> <CACsi251tM47pGdqBhx+nFB_oXLYW+tQAgibYKRUo+hQ5FeJiNg@mail.gmail.com>
From: William A Rowe Jr <wrowe@rowe-clan.net>
Date: Fri, 4 Nov 2016 21:15:12 -0500
Message-ID: <CACsi253XF8+o0DuVfn3JUV6r2j5LFqkz=fJksAYwoYQqRihpow@mail.gmail.com>
Subject: Re: svn commit: r1768079 - in /httpd/httpd/branches/2.4.x: ./ CHANGES
 STATUS docs/manual/ modules/http/http_filters.c
To: httpd <dev@httpd.apache.org>
Content-Type: multipart/alternative; boundary=001a113ed15c7765360540845c07
archived-at: Sat, 05 Nov 2016 02:15:20 -0000

--001a113ed15c7765360540845c07
Content-Type: text/plain; charset=UTF-8

On Fri, Nov 4, 2016 at 9:14 PM, William A Rowe Jr <wrowe@rowe-clan.net>
wrote:

> On Fri, Nov 4, 2016 at 5:17 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>
>> On Fri, Nov 4, 2016 at 10:15 PM, William A Rowe Jr <wrowe@rowe-clan.net>
>> wrote:
>> > I'm really not clear how ap_map_http_request_error() arrived without the
>> > patch patch below, and unclear whether it does what the backport
>> proposal
>> > intended with this work omitted.
>> >
>> > 1482522 minfrin
>> > core: Stop the HTTP_IN filter from attempting to write error buckets
>> > to the output filters, which is bogus in the proxy case. Create a
>> > clean mapping from APR codes to HTTP status codes, and use it where
>> > needed.
>>
>> The above was backported in 2.4.13 ([1]+[2]) and 2.2.30 ([3]), though
>> not exactly the same way as implemented in r1482522 (yet the intent is
>> there, and the issue fixed ;)
>>
>
> Ahhh, that's cool.
>
>
>> What differed is that http_filters' bail_out_on_error() was preserved
>> (so that [third-party-]modules don't notice/have to handle the
>> response themselves)
>
>
Which would be a brilliant solution if

 -static apr_status_t bail_out_on_error(http_ctx_t *ctx,
-                                      ap_filter_t *f,
-                                      int http_error)

Wasn't a private, unexported entry point on every sane C compiler. Sigh...

--001a113ed15c7765360540845c07
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On F=
ri, Nov 4, 2016 at 9:14 PM, William A Rowe Jr <span dir=3D"ltr">&lt;<a href=
=3D"mailto:wrowe@rowe-clan.net" target=3D"_blank">wrowe@rowe-clan.net</a>&g=
t;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0px 0=
px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div =
dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote"><span cla=
ss=3D"gmail-">On Fri, Nov 4, 2016 at 5:17 PM, Yann Ylavic <span dir=3D"ltr"=
>&lt;<a href=3D"mailto:ylavic.dev@gmail.com" target=3D"_blank">ylavic.dev@g=
mail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex"><span>On Fri, Nov 4, 2016 at 10:15 PM, William A Rowe Jr &lt;<a =
href=3D"mailto:wrowe@rowe-clan.net" target=3D"_blank">wrowe@rowe-clan.net</=
a>&gt; wrote:<br>
&gt; I&#39;m really not clear how ap_map_http_request_error() arrived witho=
ut the<br>
&gt; patch patch below, and unclear whether it does what the backport propo=
sal<br>
&gt; intended with this work omitted.<br>
&gt;<br>
&gt; 1482522 minfrin<br>
&gt; core: Stop the HTTP_IN filter from attempting to write error buckets<b=
r>
&gt; to the output filters, which is bogus in the proxy case. Create a<br>
&gt; clean mapping from APR codes to HTTP status codes, and use it where<br=
>
&gt; needed.<br>
<br>
</span>The above was backported in 2.4.13 ([1]+[2]) and 2.2.30 ([3]), thoug=
h<br>
not exactly the same way as implemented in r1482522 (yet the intent is<br>
there, and the issue fixed ;)<br></blockquote><div><br></div></span><div>Ah=
hh, that&#39;s cool.</div><span class=3D"gmail-"><div>=C2=A0<br></div><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:=
1px solid rgb(204,204,204);padding-left:1ex">
What differed is that http_filters&#39; bail_out_on_error() was preserved<b=
r>
(so that [third-party-]modules don&#39;t notice/have to handle the<br>
response themselves)</blockquote></span></div></div></div></blockquote><div=
><br></div><div>Which would be a brilliant solution if</div><div><br></div>=
<div>=C2=A0-static apr_status_t bail_out_on_error(http_ctx_t *ctx,</div><di=
v>- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ap_filter_t *=
f,</div><div>- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0in=
t http_error)</div><div><br></div><div>Wasn&#39;t a private, unexported ent=
ry point on every sane C compiler. Sigh...</div></div></div></div>

--001a113ed15c7765360540845c07--