httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: ap_get_status_line(int)
Date Tue, 15 Nov 2016 09:09:48 GMT
On Fri, Nov 4, 2016 at 5:51 PM, Stefan Eissing
<stefan.eissing@greenbytes.de> wrote:
>
> The patch looks fine to me. I do just feel a tad bit uncomfortable with the
> empty description. How about
> +        return apr_psprintf(p, "%i No Description", status);
>
> There are probably tons of client implementations out there that will fail
> when nothing comes after the space.

Good point, committed in r1769760 with: apr_psprintf(p, "%i Status
%i", status, status).

Regards,
Yann.

Mime
View raw message