Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: <20161018163044.14EFE3A0CBA@svn01-us-west.apache.org>
References: <20161018163044.14EFE3A0CBA@svn01-us-west.apache.org>
From: William A Rowe Jr <wrowe@rowe-clan.net>
Date: Tue, 18 Oct 2016 12:28:05 -0500
Message-ID: <CACsi252LoLazUY0Z+tu01CrPTzqCmfXDwoy2NGAPF+K8VQ_8Qg@mail.gmail.com>
Subject: Re: svn commit: r1765475 - /httpd/httpd/trunk/modules/http/http_filters.c
To: httpd <dev@httpd.apache.org>
Content-Type: multipart/alternative; boundary=94eb2c05aa2af2b5ea053f27035c
archived-at: Tue, 18 Oct 2016 17:28:17 -0000

--94eb2c05aa2af2b5ea053f27035c
Content-Type: text/plain; charset=UTF-8

Personally, I find this case of 1*hexdig ";" to more closely resemble
the new rule of field-name ":" OWS field-value, which introduces a
MUST reject for whitespace following request field-name in 7230 3.2.4.
But  Roy accepts that the implied *LWS rule is appropriate based on
the errata request, and I'm fine with accepting that approach. Note
we now implement this as;
*hexdig [#10 LWS [ ";" *( VCHAR | obs-text | SP | TAB ) ] ].

If there are other opinions please speak up in the coming days.

Cheers,

Bill


On Tue, Oct 18, 2016 at 11:30 AM, <wrowe@apache.org> wrote:

> Author: wrowe
> Date: Tue Oct 18 16:30:43 2016
> New Revision: 1765475
>
> URL: http://svn.apache.org/viewvc?rev=1765475&view=rev
> Log:
> Appears we cannot disallow this whitespace, since the chunk BNF coexisted
> with the implied *LWS rule, before RFC7230 eliminated the later. Whether
> this is actually OWS or BWS is an editorial decision beyond our pay grade.
>
>
>
> Modified:
>     httpd/httpd/trunk/modules/http/http_filters.c
>
> Modified: httpd/httpd/trunk/modules/http/http_filters.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/
> http/http_filters.c?rev=1765475&r1=1765474&r2=1765475&view=diff
> ============================================================
> ==================
> --- httpd/httpd/trunk/modules/http/http_filters.c (original)
> +++ httpd/httpd/trunk/modules/http/http_filters.c Tue Oct 18 16:30:43 2016
> @@ -179,8 +179,10 @@ static apr_status_t parse_chunk_size(htt
>                  return APR_EINVAL;
>              }
>          }
> -        else if (!strict && (c == ' ' || c == '\t')) {
> -            /* Be lenient up to 10 BWS (term from rfc7230 - 3.2.3).
> +        else if (c == ' ' || c == '\t') {
> +            /* Be lenient up to 10 implied *LWS, a legacy of RFC 2616,
> +             * and noted as errata to RFC7230;
> +             * https://www.rfc-editor.org/errata_search.php?rfc=7230&
> eid=4667
>               */
>              ctx->state = BODY_CHUNK_CR;
>              if (++ctx->chunk_bws > 10) {
>
>
>

--94eb2c05aa2af2b5ea053f27035c
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Personally, I find this case of 1*hexdig &quot;;&quot; to =
more closely resemble<div>the new rule of field-name &quot;:&quot; OWS fiel=
d-value, which introduces a</div><div>MUST reject for whitespace following =
request field-name in 7230 3.2.4.</div><div>But =C2=A0Roy accepts that the =
implied *LWS rule is appropriate based on</div><div>the errata request, and=
 I&#39;m fine with accepting that approach. Note</div><div>we now implement=
 this as;</div><div>*hexdig [#10 LWS [ &quot;;&quot; *( VCHAR | obs-text | =
SP | TAB ) ] ].</div><div><br></div><div>If there are other opinions please=
 speak up in the coming days.</div><div><br></div><div>Cheers,</div><div><b=
r></div><div>Bill</div><div><br></div></div><div class=3D"gmail_extra"><br>=
<div class=3D"gmail_quote">On Tue, Oct 18, 2016 at 11:30 AM,  <span dir=3D"=
ltr">&lt;<a href=3D"mailto:wrowe@apache.org" target=3D"_blank">wrowe@apache=
.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: wrowe<=
br>
Date: Tue Oct 18 16:30:43 2016<br>
New Revision: 1765475<br>
<br>
URL: <a href=3D"http://svn.apache.org/viewvc?rev=3D1765475&amp;view=3Drev" =
rel=3D"noreferrer" target=3D"_blank">http://svn.apache.org/viewvc?<wbr>rev=
=3D1765475&amp;view=3Drev</a><br>
Log:<br>
Appears we cannot disallow this whitespace, since the chunk BNF coexisted<b=
r>
with the implied *LWS rule, before RFC7230 eliminated the later. Whether<br=
>
this is actually OWS or BWS is an editorial decision beyond our pay grade.<=
br>
<br>
<br>
<br>
Modified:<br>
=C2=A0 =C2=A0 httpd/httpd/trunk/modules/<wbr>http/http_filters.c<br>
<br>
Modified: httpd/httpd/trunk/modules/<wbr>http/http_filters.c<br>
URL: <a href=3D"http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http=
/http_filters.c?rev=3D1765475&amp;r1=3D1765474&amp;r2=3D1765475&amp;view=3D=
diff" rel=3D"noreferrer" target=3D"_blank">http://svn.apache.org/viewvc/<wb=
r>httpd/httpd/trunk/modules/<wbr>http/http_filters.c?rev=3D<wbr>1765475&amp=
;r1=3D1765474&amp;r2=3D1765475&amp;<wbr>view=3Ddiff</a><br>
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D<wbr>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<wbr>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D<br>
--- httpd/httpd/trunk/modules/<wbr>http/http_filters.c (original)<br>
+++ httpd/httpd/trunk/modules/<wbr>http/http_filters.c Tue Oct 18 16:30:43 =
2016<br>
@@ -179,8 +179,10 @@ static apr_status_t parse_chunk_size(htt<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return APR_EI=
NVAL;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 else if (!strict &amp;&amp; (c =3D=3D &#39; &#=
39; || c =3D=3D &#39;\t&#39;)) {<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Be lenient up to 10 BWS (term=
 from rfc7230 - 3.2.3).<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 else if (c =3D=3D &#39; &#39; || c =3D=3D &#39=
;\t&#39;) {<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Be lenient up to 10 implied *=
LWS, a legacy of RFC 2616,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* and noted as errata to R=
FC7230;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* <a href=3D"https://www.r=
fc-editor.org/errata_search.php?rfc=3D7230&amp;eid=3D4667" rel=3D"noreferre=
r" target=3D"_blank">https://www.rfc-editor.org/<wbr>errata_search.php?rfc=
=3D7230&amp;<wbr>eid=3D4667</a><br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 */<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ctx-&gt;state =3D BODY_CHUN=
K_CR;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (++ctx-&gt;chunk_bws &gt=
; 10) {<br>
<br>
<br>
</blockquote></div><br></div>

--94eb2c05aa2af2b5ea053f27035c--