Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: <CALK=YjN_ZTt6C3Tsqn1aq4XRRrVGJP0q5pYZEz9mxiYpRhXmsQ@mail.gmail.com>
References: <20150630084017.C9616AC0043@hades.apache.org> <CALK=YjN_ZTt6C3Tsqn1aq4XRRrVGJP0q5pYZEz9mxiYpRhXmsQ@mail.gmail.com>
From: William A Rowe Jr <wrowe@rowe-clan.net>
Date: Fri, 14 Oct 2016 14:44:56 -0500
Message-ID: <CACsi250JWZS5B5Fv9c2pYn-xVUToUq+XXYQB6bKZ28Vk-PNRRA@mail.gmail.com>
Subject: Re: svn commit: r1688399 - /httpd/httpd/trunk/modules/metadata/mod_remoteip.c
To: httpd <dev@httpd.apache.org>
Content-Type: multipart/alternative; boundary=94eb2c05aa2afd4119053ed875ad
archived-at: Fri, 14 Oct 2016 19:45:00 -0000

--94eb2c05aa2afd4119053ed875ad
Content-Type: text/plain; charset=UTF-8

On Fri, Oct 14, 2016 at 11:16 AM, Eric Covener <covener@gmail.com> wrote:

> This was not backported and popped up in PR60251.
>
> Bill, can you have a look including my guess that it really should
> just be "temp_sa = r->useragent_addr;"?


While that code should *not* be triggered before r->useragent_addr
has been populated, some off-beat perl code causes these phases
to run out-of-sequence and we segfault not long after if this is run
without a post read request hook.

I blame a bad mod_perl example, but the cycle wasted to confirm
that useragent_addr is non-null isn't worth trimming.

--94eb2c05aa2afd4119053ed875ad
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On F=
ri, Oct 14, 2016 at 11:16 AM, Eric Covener <span dir=3D"ltr">&lt;<a href=3D=
"mailto:covener@gmail.com" target=3D"_blank">covener@gmail.com</a>&gt;</spa=
n> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;b=
order-left:1px #ccc solid;padding-left:1ex">This was not backported and pop=
ped up in PR60251.<br>
<br>
Bill, can you have a look including my guess that it really should<br>
just be &quot;temp_sa =3D r-&gt;useragent_addr;&quot;?</blockquote><div><br=
></div><div>While that code should *not* be triggered before r-&gt;useragen=
t_addr<br></div><div>has been populated, some off-beat perl code causes the=
se phases</div><div>to run out-of-sequence and we segfault not long after i=
f this is run</div><div>without a post read request hook.</div><div><br></d=
iv><div>I blame a bad mod_perl example, but the cycle wasted to confirm</di=
v><div>that useragent_addr is non-null isn&#39;t worth trimming.</div><div>=
<br></div><div><br></div></div></div></div>

--94eb2c05aa2afd4119053ed875ad--