httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Champion <champio...@gmail.com>
Subject Re: [PATCH] Introducing mod_brotli
Date Thu, 20 Oct 2016 00:37:59 GMT
On 09/16/2016 05:32 AM, Evgeny Kotkov wrote:
> This patch adds a module for dynamic Brotli (RFC 7932) compression in httpd.

Just in case someone else runs into this: I gave mod_brotli a shot after 
a user on #httpd-dev asked about Brotli compression, and it immediately 
ran my test server out of memory. :(

The issue appears to be that the libbrotli ABI changes depending on the 
C standard in use. (Specifically, the BROTLI_BOOL type is either C99's 
_Bool or an enum.) So mod_brotli, compiled in maintainer-mode (C89), 
thinks that "false" boolean values coming back from the library are 
"true". This leads to some fun infinite loops.

I've commented upstream, since it looks like the switch from 'int' to 
'BROTLI_BOOL' was explicitly requested by another user:

     https://github.com/google/brotli/issues/384

--Jacob

Mime
View raw message