Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3CFA7200B6B for ; Fri, 9 Sep 2016 15:35:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3B790160AC2; Fri, 9 Sep 2016 13:35:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5E418160AB6 for ; Fri, 9 Sep 2016 15:35:49 +0200 (CEST) Received: (qmail 66772 invoked by uid 500); 9 Sep 2016 13:35:48 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 66758 invoked by uid 99); 9 Sep 2016 13:35:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Sep 2016 13:35:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B48C0C1AB9 for ; Fri, 9 Sep 2016 13:35:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XnGOcqLmjQMX for ; Fri, 9 Sep 2016 13:35:46 +0000 (UTC) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 7E50A5FAFA for ; Fri, 9 Sep 2016 13:35:46 +0000 (UTC) Received: by mail-lf0-f51.google.com with SMTP id u14so44388803lfd.1 for ; Fri, 09 Sep 2016 06:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=ReMwn/O4I6+N/rAZOz4S6O3GHFYwHGLr5vfDhlUa70A=; b=q4qjirLFQgRcGxu+22Sbwus5HTLvhqvrCJYJG8Vk1fSO0uxYb+esCckLPBhbE5mENl k0oq0lQbTjDCh0q18IOVxAkd5ngDzC7Myt9ApvUTudXij4b8OSuiO7ShUzx2YBPYVrny NIvoSqN1UGf9s/P8WtlXZBzCFU4Xna4s0nraSd9C02YsRAuITCbFN+I20xFpSjrV61zr zaMpQkLbThmRmDffZfP5yEQCSYrZhjjRBoWHLaS1ghkZZJjkhvyrnsroKJMt4+t8bFsr sx+kL1FPAxy076NEtm2Rw0WHkUab0Lv2jrUnxFJ/Aj8Z35LbejEOOBCzdZwUoOWs89RQ Wtow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=ReMwn/O4I6+N/rAZOz4S6O3GHFYwHGLr5vfDhlUa70A=; b=hXDbLcGKZo72diVw39JRUz6KP6Y3Dg2miWG98w+OIk1zHJMeKEbYsfjy6oC0yoaqMF Ob7Qe+CvWcQjZZEl1GwYkSQ5GiN7Omp5sepsaCBN5qXKq65501+824tHwBh4+mLzuO7E ldJ731dzihFfOQ3WYrzy3Idj+hpHMkqhHRX4yKxi05Of7K8ZKCZnYaQe3ABQMw9SHyty Pn6z9SyrTrtwdfeqGR4KDFyqn8wcotjdJ5p9bGP7aDjc1+ODEMBGOgSmF5mIHVNFhz5S EKrzdCUP6l5b4IRF0Wmi0LbtE+I+yI9nWl8srfcbxaycMmHYNy6Gpna5uA8ELFSuNhPI L2NQ== X-Gm-Message-State: AE9vXwPKinMYfwN1rFJGCr5e3I8UagjBgiNMq7S9/XzGbJ5YCBayrYp8JNR1OJh1JP3bQHLqgMqRzDUvX23EUg== X-Received: by 10.25.158.66 with SMTP id h63mr1038290lfe.155.1473428144866; Fri, 09 Sep 2016 06:35:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.81.11 with HTTP; Fri, 9 Sep 2016 06:35:44 -0700 (PDT) In-Reply-To: <57D2B683.7000908@apache.org> References: <20160909111736.F03D13A0249@svn01-us-west.apache.org> <57D2B683.7000908@apache.org> From: Luca Toscano Date: Fri, 9 Sep 2016 15:35:44 +0200 Message-ID: Subject: Re: svn commit: r1759984 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c To: Apache HTTP Server Development List Content-Type: multipart/alternative; boundary=001a114019182d4e95053c133994 archived-at: Fri, 09 Sep 2016 13:35:50 -0000 --001a114019182d4e95053c133994 Content-Type: text/plain; charset=UTF-8 2016-09-09 15:17 GMT+02:00 Ruediger Pluem : > > > On 09/09/2016 01:17 PM, elukey@apache.org wrote: > > Author: elukey > > Date: Fri Sep 9 11:17:36 2016 > > New Revision: 1759984 > > > > URL: http://svn.apache.org/viewvc?rev=1759984&view=rev > > Log: > > mod_proxy_fcgi: handle the HTTP 412 use case > > > > This is a follow up of http://svn.apache.org/r1752347; > > ap_meet_conditions could return a 412 status that if not > > handled causes subsequent bogus reads and wrong messages > > logged (like AH01070). After a chat on dev@ the feedback > > was to couple HTTP_NOT_MODIFIED with HTTP_PRECONDITION_FAILED, > > but any other feedback is welcome. > > > > > > Modified: > > httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c > > > > Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c > > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ > proxy/mod_proxy_fcgi.c?rev=1759984&r1=1759983&r2=1759984&view=diff > > ============================================================ > ================== > > --- httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c (original) > > +++ httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c Fri Sep 9 > 11:17:36 2016 > > @@ -660,13 +660,17 @@ recv_again: > > *err = "passing headers brigade to > output filters"; > > break; > > } > > - else if (status == HTTP_NOT_MODIFIED) { > > - /* The 304 response MUST NOT contain > > - * a message-body, ignore it. > > + else if (status == HTTP_NOT_MODIFIED > > + || HTTP_PRECONDITION_FAILED) { > > I guess that should be status == HTTP_PRECONDITION_FAILED > > instead. Fixed in r1760018, thanks a lot for spotting the mistake! I have no idea how I missed it, really sorry.. Regards, Luca --001a114019182d4e95053c133994 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-09-09 15:17 GMT+02:00 Ruediger Pluem <rpluem@apache.org>:


On 09/09/2016 01:17 PM, elukey@apache.= org wrote:
> Author: elukey
> Date: Fri Sep=C2=A0 9 11:17:36 2016
> New Revision: 1759984
>
> URL: http://svn.apache.org/viewvc?rev=3D1759984&view=3Drev
> Log:
> mod_proxy_fcgi: handle the HTTP 412 use case
>
> This is a follow up of http://svn.apache.org/r1752347;<= br> > ap_meet_conditions could return a 412 status that if not
> handled causes subsequent bogus reads and wrong messages
> logged (like AH01070). After a chat on dev@ the feedback
> was to couple HTTP_NOT_MODIFIED with HTTP_PRECONDITION_FAILED,
> but any other feedback is welcome.
>
>
> Modified:
>=C2=A0 =C2=A0 =C2=A0httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi= .c
>
> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c
> URL: http://svn.apache.org/vi= ewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c?rev=3D= 1759984&r1=3D1759983&r2=3D1759984&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c (original) > +++ httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c Fri Sep=C2= =A0 9 11:17:36 2016
> @@ -660,13 +660,17 @@ recv_again:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 *err =3D &qu= ot;passing headers brigade to output filters";
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 else if (status =3D=3D HTTP_NOT_= MODIFIED) {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* The 304 respons= e MUST NOT contain
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* a message-= body, ignore it.
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 else if (status =3D=3D HTTP_NOT_= MODIFIED
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0|| HTTP_PRECONDITION_FAILED) {

I guess that should be status =3D=3D=C2=A0 HTTP_PRECONDITION_FA= ILED

instead.

Fixed in r1760018, thanks a lot fo= r spotting the mistake! I have no idea how I missed it, really sorry..

Regards,

Luca
--001a114019182d4e95053c133994--