httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Evgeny Kotkov <evgeny.kot...@visualsvn.com>
Subject Re: svn commit: r1761714 - in /httpd/httpd/trunk: CHANGES CMakeLists.txt docs/log-message-tags/next-number modules/filters/config.m4 modules/filters/mod_brotli.c os/win32/BaseAddr.ref
Date Wed, 21 Sep 2016 22:16:49 GMT
Ruediger Pluem <rpluem@apache.org> writes:

>> +    ac_brotli_libs="${ac_brotli_libs:--lbrotlienc `$apr_config --libs`} "
>> +    APR_ADDTO(MOD_LDFLAGS, [$ac_brotli_libs])
>
> This breaks compilation of trunk if libbrotlienc is not present as it is
> added unconditionally. But even if would be added conditionally I sense
> that all filters would be linked against libbrotlienc. So better only add
> to MOD_BROTLI_LDADD instead of MOD_LDFLAGS

Indeed, I totally messed up this part of the configuration script.  Sorry
for that.

I committed a rework of this part in r1761824 [1], and it fixes this build
issue for me.  Could you please check it in your environment as well?

[1] https://svn.apache.org/r1761824


Thanks,
Evgeny Kotkov

Mime
View raw message