Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8332F200B5A for ; Thu, 4 Aug 2016 17:46:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 81A77160AAB; Thu, 4 Aug 2016 15:46:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C5BD2160A6A for ; Thu, 4 Aug 2016 17:46:36 +0200 (CEST) Received: (qmail 68759 invoked by uid 500); 4 Aug 2016 15:46:35 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 68744 invoked by uid 99); 4 Aug 2016 15:46:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Aug 2016 15:46:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D275E1885CD for ; Thu, 4 Aug 2016 15:46:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.821 X-Spam-Level: X-Spam-Status: No, score=-0.821 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id EgTBJ-U4dr9q for ; Thu, 4 Aug 2016 15:46:31 +0000 (UTC) Received: from mail-qt0-f169.google.com (mail-qt0-f169.google.com [209.85.216.169]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BA6EC5FAEE for ; Thu, 4 Aug 2016 15:46:30 +0000 (UTC) Received: by mail-qt0-f169.google.com with SMTP id 52so160774094qtq.3 for ; Thu, 04 Aug 2016 08:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=LK1LdsF4/zbwkLehlzqDaThWL+GQOsV2onBFJdss/0M=; b=umEa+IdY7KQpKosFbx78rNHSFBY/DnlYO0O4Tw1ZS0NtNnTX7ntd79BLwWL98tcCco YYTgFxSxfN7sVDVFyOwzH0h2XAzdxhGs/s4kumxvUPIFeq3Ed1qD/2pssmjZcGKov+pY nHL++Z9PL5/F3+6C0AEbfXlTbmTyR6spgfNfeFdsmzUIJRA+rwNQJInpq3OcoU3EjesW XevQDQEXC20m76OCHJpsoWvEIJRrzziJqZC6DgxaJ+OssMZ9IjivrrVyhjxG68Eo4MSd LnozFxfzWPlF8Cpr2D3o/5P1bIlC4VUs+lUXGBa9ojC58SxelYBQNitAHDVhyD/F/LXJ Fw7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=LK1LdsF4/zbwkLehlzqDaThWL+GQOsV2onBFJdss/0M=; b=E7yK+eKb4Xc29IJSf139Snpx6ZxtRwJYVEnRXAbrmZI61QHYX233/ZRCNSloVuuXXu CaDumqAlHd046F8jGb6Ry1sTwd5Xd5Dox3cUqG8QMnQj8xqZyd5GezwPf2WbxHFkfA73 okhq92YdtL9eP1ewGJ4+JHFbUY3vo8LegszYPdlUYAxTfn76pahMAXJKEnlDuciZ2hrk Wh3cl4E7xvLm3zDSiD5BHnRzhRP74Y6f9nGLyBnVPszEYdE039P5rszlSh2g9v+bb/9Z J2yR5YFmX2n0iGt/DrfbgZ2PpdlI5/cB5zEeDEKAE99QQ/Gle9O0w9JteaVnPd12aHS3 dzHw== X-Gm-Message-State: AEkoouvG47dKG+ifEDNXKznf5YBZA0FzfnmxpP+rAiHTwNVCe7c8pVfPTt6jEO/Zq8T6IdiqWG69NOmbv4+OPw== X-Received: by 10.200.34.135 with SMTP id f7mr7055535qta.141.1470325583840; Thu, 04 Aug 2016 08:46:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.97.206 with HTTP; Thu, 4 Aug 2016 08:46:23 -0700 (PDT) In-Reply-To: References: From: Yann Ylavic Date: Thu, 4 Aug 2016 17:46:23 +0200 Message-ID: Subject: Re: mod_remoteip DNS address resolution To: httpd-dev Content-Type: text/plain; charset=UTF-8 archived-at: Thu, 04 Aug 2016 15:46:37 -0000 On Thu, Aug 4, 2016 at 3:30 PM, Rainer Jung wrote: > > - apr_ipsubnet_create() has some logic, that for instance accepts "192.168" > as input with NULL mask_or_numbits and returns sub 192.168.0.0 and mask > 255.255.0.0. Hmm, indeed, but this looks buggy to me. Shouldn't apr_ipsubnet_create() be fixed with: - rv = parse_ip(*ipsub, ipstr, mask_or_numbits == NULL); + rv = parse_ip(*ipsub, ipstr, mask_or_numbits != NULL); ?