httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1755263 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/protocol.c
Date Fri, 05 Aug 2016 11:55:44 GMT
On Fri, Aug 5, 2016 at 1:25 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> On Fri, Aug 5, 2016 at 11:08 AM,  <wrowe@apache.org> wrote:
>>
>> -            if (field[1] != '\0') {
>> -                /* ...and leading whitespace on an obs-fold line can be
>> -                 * similarly discarded */
>> -                while (field[1] == '\t' || field[1] == ' ') {
>> -                    ++field; --len;
>> -                }
>> +            if (field[1] == '\0') {
>> +                r->status = HTTP_BAD_REQUEST;
>> +                ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03443)
>> +                              "Empty folded line encountered");
>> +                return;
>> +            }
>> +
>> +            /* Leading whitespace on an obs-fold line can be
>> +             * similarly discarded */
>> +            while (field[1] == '\t' || field[1] == ' ') {
>> +                ++field; --len;
>>              }
>
> Empty folded line can still happen here (after discarding obs-fold spaces).

Hmm no, sorry for the noise, trailing spaces discarding above would
have set field[1] = '\0'.

Mime
View raw message