httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: mod_remoteip DNS address resolution
Date Thu, 04 Aug 2016 15:46:23 GMT
On Thu, Aug 4, 2016 at 3:30 PM, Rainer Jung <rainer.jung@kippdata.de> wrote:
>
> - apr_ipsubnet_create() has some logic, that for instance accepts "192.168"
> as input with NULL mask_or_numbits and returns sub 192.168.0.0 and mask
> 255.255.0.0.

Hmm, indeed, but this looks buggy to me.
Shouldn't apr_ipsubnet_create() be fixed with:

-    rv = parse_ip(*ipsub, ipstr, mask_or_numbits == NULL);
+    rv = parse_ip(*ipsub, ipstr, mask_or_numbits != NULL);

?

Mime
View raw message