httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1756978 - /httpd/httpd/trunk/server/gen_test_char.c
Date Sun, 21 Aug 2016 14:49:54 GMT
On Sat, Aug 20, 2016 at 2:53 AM,  <wrowe@apache.org> wrote:
>
> Modified: httpd/httpd/trunk/server/gen_test_char.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/gen_test_char.c?rev=1756978&r1=1756977&r2=1756978&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/server/gen_test_char.c (original)
> +++ httpd/httpd/trunk/server/gen_test_char.c Sat Aug 20 00:53:38 2016
> @@ -143,9 +143,9 @@ int main(int argc, char *argv[])
>           * and unreserved (2.3) that are possible somewhere within a URI.
>           * Spec requires all others to be %XX encoded, including obs-text.
>           */
> -        if (c && strchr(":/?#[]@"                       /* gen-delims */
> -                        "!$&'()*+,;="                   /* sub-delims */
> -                        "-._~", c) || apr_isalnum(c)) { /* unreserved */
> +        if (c && (strchr(":/?#[]@"                        /* gen-delims */
> +                         "!$&'()*+,;="                    /* sub-delims */
> +                         "-._~", c) || apr_isalnum(c))) { /* unreserved */
>              flags |= T_URI_RFC3986;
>          }

This is missing '%' which makes several tests to fail in framework.

t/modules/digest.t                (Wstat: 0 Tests: 13 Failed: 3)
  Failed tests:  4-5, 10
t/modules/proxy.t                 (Wstat: 0 Tests: 18 Failed: 1)
  Failed test:  11
t/modules/rewrite.t               (Wstat: 0 Tests: 33 Failed: 5)
  Failed tests:  23-26, 28

Regards,
Yann.

Mime
View raw message