httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From William A Rowe Jr <wr...@rowe-clan.net>
Subject Re: svn commit: r1755098 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/protocol.c
Date Wed, 03 Aug 2016 23:14:13 GMT
On Wed, Aug 3, 2016 at 4:58 PM, William A Rowe Jr <wrowe@rowe-clan.net>
wrote:

> On Wed, Aug 3, 2016 at 3:21 PM, Jacob Champion <champion.p@gmail.com>
>> wrote:
>>
>>>
>>> I don't think this is an equivalent transformation. More logic below
>>> this case relies on the last_field NULL check, and I'm currently getting
>>> segfaults on trunk due to the strchr on line 907.
>>>
>>
>> You were correct, that was my oversight. It was easier to simply revert
> the
> work so that I'm not overlaying one whitespace change after another, since
> the fix causes everything to be re-indented anyways, so we are back to
> trunk of last evening before my patches this morning.
>

And I've reapplied the now-corrected logic. Thanks for your detailed and
careful review of these changes, please feel free to review this code again
offer any feedback.

We'll fix the obs-fold whitespace question next.

Cheers,

Bill

Mime
View raw message