Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AB45F200B40 for ; Fri, 1 Jul 2016 13:44:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A9D5A160A61; Fri, 1 Jul 2016 11:44:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AA4B2160A5D for ; Fri, 1 Jul 2016 13:44:47 +0200 (CEST) Received: (qmail 56039 invoked by uid 500); 1 Jul 2016 11:44:46 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 56029 invoked by uid 99); 1 Jul 2016 11:44:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2016 11:44:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0BD56C02E8 for ; Fri, 1 Jul 2016 11:44:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.279 X-Spam-Level: * X-Spam-Status: No, score=1.279 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=ocado-com.20150623.gappssmtp.com Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3Y4u2FKqcsVA for ; Fri, 1 Jul 2016 11:44:44 +0000 (UTC) Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 858945F476 for ; Fri, 1 Jul 2016 11:44:43 +0000 (UTC) Received: by mail-wm0-f49.google.com with SMTP id a66so25627352wme.0 for ; Fri, 01 Jul 2016 04:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ocado-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Ccpx/mgOYL9BSoZR5zUxlGuBxY/FpossGrnN74bevJ0=; b=Hyl92UyQuBUEAx67Pz6y6jf76ydpUbPjBd32/9aTD+ywMFYOj4ZKx6kHcDp5M/61wX 26s8jmwrzkYpDw7gRk7zofGo/tzoknSRN1aHIF09wr6tsSbwzzG+djLny0CFMX7/ntr3 VJoXP9wIiBg0WkfNejkUwISyn1u+1bth6RpDlym1rP9imoaOUvNHwq+2ytQiwmheCWoS EBD80yPrNyfQRtz6h56VNzDyVRNkpWC+/iiEcbTk0T5GHbPqRdBiHe+bHKjx8qWvEFHo pauBg+15eMDu0iUPflLUdzbl4R7ouT6DTsHOBj3ETzn5eOAKEv1NI4lWtGEFG6g0CKGD cfsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Ccpx/mgOYL9BSoZR5zUxlGuBxY/FpossGrnN74bevJ0=; b=dJPtWifjR/LZvjBWIngn8FRvy3+IvCJ9xMcA9GXlyZ0ognm7YQh78aZWTviCr+bN/E Y//qXfPMhWhA+eJIuyUGOs6l6s4GtW75kzBl9VIZ9Sp+eSx6xVbNDE6DTlNSwT9fCJn5 ITzb9wSQzq8yk4J5uh6oBbNuu4sxxzwufFdB6WKqOvozCroeqWSIsEhmYCaqMh+9GRom 8ojVVgi3maRah6wXv9yns9vuKlVZcbLuE152iVDEr1baHD3KW1G5no5mcIQ95ZkJts7k XoRI4kR2HnqaRkGzLs64Nu8N3nuWKMfRtDCevUrNpCsSnZvgRzDPg50ErCVRCjs02LFm wdLQ== X-Gm-Message-State: ALyK8tK3ACMk3nJXDCFbMJgcIhOVQTW1mtAkjEJ+lG9p7phpxqCkbphF7+UeLxAD15sPK0XRVJ/a9vpRA8yQU7zvZ8Nc2jrMGOXWasH0FH1nLTMqqiH6EjCaQ1AeD0o8sIEGNysNHDuHlTrl X-Received: by 10.28.227.136 with SMTP id a130mr33545328wmh.3.1467373482968; Fri, 01 Jul 2016 04:44:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.66.199 with HTTP; Fri, 1 Jul 2016 04:44:42 -0700 (PDT) In-Reply-To: References: From: Pietro Paolini Date: Fri, 1 Jul 2016 12:44:42 +0100 Message-ID: Subject: Re: Apache Benchmark SNI SSL To: dev@httpd.apache.org Content-Type: multipart/alternative; boundary=001a114b118234afab053691836f archived-at: Fri, 01 Jul 2016 11:44:48 -0000 --001a114b118234afab053691836f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 1 July 2016 at 11:18, Pietro Paolini wrote: > > > On 30 June 2016 at 19:55, Yann Ylavic wrote: > >> On Thu, Jun 30, 2016 at 7:21 PM, Pietro Paolini >> wrote: >> > >> > I have built the httpd-2-.4.20 tarball but the problem is still there, >> has >> > it been fixed in newer version ? is there a workaround for that ? >> >> SNI handling just added to ab in http://svn.apache.org/r1750854. >> It will be part of some future release when accepted by the community, >> meanwhile maybe you can patch your current release with the commit >> above. >> >> Regards, >> Yann. >> > > Is it correct ? It does not look good to me. > > - while ((status =3D apr_getopt(opt, > "n:c:t:s:b:T:p:u:v:lrkVhwix:y:z:C:H:P:A:g:X:de:SqB:m:" > + while ((status =3D apr_getopt(opt, > "n:c:t:s:b:T:p:u:v:lrkVhwixI:y:z:C:H:P:A:g:X:de:SqB:m:" > > The x option has lost its argument, the new option you have introduced > uses an argument but the : > > + fprintf(stderr, " -I Use TLS Server Name Indication (SNI) > extension\n"); > > Does not tell that. > > The ab tool print the helper and quits without doing anything, I have > applied the patch on the top of the httpd-2.4.20 though, I am working a b= it > on that, even though given my poor knowledge of the project itself I do n= ot > think I can't go anywhere but hardcoding: > > + SSL_set_tlsext_host_name(c->ssl, "myserverhost"); > > If I can be of any help - such testing - feel free to drag me in. > > Thanks, > Pietro > > > To fix the patch you just need to > - while ((status =3D apr_getopt(opt, "n:c:t:s:b:T:p:u:v:lrkVhwix:y:z:C:H:P:A:g:X:de:SqB:m:" + while ((status =3D apr_getopt(opt, "n:c:t:s:b:T:p:u:v:lrkVhwiIx:y:z:C:H:P:A:g:X:de:SqB:m:" That will do the job, as it stands right now it will be working if given a -I option with a random argument, for example : ./support/ab -I randomstring -c 1 -n 1 https://whatever/url The I argument is actually not used. Cheers, P. --=20 Notice: This email is confidential and may contain copyright material of= =20 members of the Ocado Group. Opinions and views expressed in this message=20 may not necessarily reflect the opinions and views of the members of the=20 Ocado Group.=20 =20 If you are not the intended recipient, please notify us immediately and=20 delete all copies of this message. Please note that it is your=20 responsibility to scan this message for viruses.=20 =20 Fetch and Sizzle are trading names of Speciality Stores Limited, a member= =20 of the Ocado Group. =20 References to the =E2=80=9COcado Group=E2=80=9D are to Ocado Group plc (reg= istered in=20 England and Wales with number 7098618) and its subsidiary undertakings (as= =20 that expression is defined in the Companies Act 2006) from time to time. = =20 The registered office of Ocado Group plc is Titan Court, 3 Bishops Square,= =20 Hatfield Business Park, Hatfield, Herts. AL10 9NE. --001a114b118234afab053691836f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 1 July 2016 at 11:18, Pietro Paolini <pietro.paolini@ocado= .com> wrote:


On 30 June 2016 at 19:55, Yann Ylavic <= ylavic.dev@gmail.com> wrote:
On Thu, Jun 30, 2016 at 7:21 PM, Pietro Paolini<= br> <pietro.pa= olini@ocado.com> wrote:
>
> I have built the httpd-2-.4.20 tarball but the problem is still there,= has
> it been fixed in newer version ? is there a workaround for that ?

SNI handling just added to ab in http://svn.apache.org/r1750854= .
It will be part of some future release when accepted by the community,
meanwhile maybe you can patch your current release with the commit
above.

Regards,
Yann.

Is it correct ? It do= es not look good to me.

=C2=A0-=C2=A0=C2=A0=C2=A0 while ((status =3D= apr_getopt(opt, "n:c:t:s:b:T:p:u:v:lrkVhwix:y:z:C:H:P:A:g:X:de:SqB:m:= "
+=C2=A0=C2=A0=C2=A0 while ((status =3D apr_getopt(opt, "n:c:= t:s:b:T:p:u:v:lrkVhwixI:y:z:C:H:P:A:g:X:de:SqB:m:"
=C2=A0
=
The x option has lost its argument, the new option you have introduced= uses an argument but the :

+=C2=A0=C2=A0=C2=A0 fprintf(stderr, &quo= t;=C2=A0=C2=A0=C2=A0 -I Use TLS Server Name Indication (SNI) extension\n&qu= ot;);

Does not tell that.

The ab tool p= rint the helper and quits without doing anything, I have applied the patch = on the top of the httpd-2.4.20 though, I am working a bit on that, even tho= ugh given my poor knowledge of the project itself I do not think I can'= t go anywhere but hardcoding:

+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 SSL_set_tlsext_host_name(c->ssl, "my= serverhost");

If I can be of any help - such testing= - feel free to drag me in.

Thanks,
Pietro<= br>


To fix the patch you just need to

=C2=A0-=C2=A0=C2=A0=C2=A0 while ((status =3D= apr_getopt(opt, "n:c:t:s:b:T:p:u:v:lrkVhwix:y:z:C:H:P:A:g:X:de:SqB:m:= "
=C2=A0+=C2=A0=C2=A0=C2=A0 while ((status =3D apr_getopt(opt, &quo= t;n:c:t:s:b:T:p:u:v:lrkVhwiIx:y:z:C:H:P:A:g:X:de:SqB:m:"

=

That will do the job, as it stands right now it will be= working if given a -I option with a random argument, for example :

= ./support/ab -I randomstring=C2=A0 -c 1 -n 1 https://whatever/url

The I argument is actually no= t used.

Cheers,
P.


Notice:=C2=A0 This email is confid= ential and may contain copyright material of members of the Ocado Group. Op= inions and views expressed in this message may not necessarily reflect the = opinions and views of the members of the Ocado Group.=C2=A0

=C2=A0

If you are not the intended recipient, please notify us = immediately and delete all copies of this message. Please note that it is y= our responsibility to scan this message for viruses.=C2=A0

=C2=A0

Fetch and Sizzle are trading names of Speciality Stores L= imited, a member of the Ocado Group.

=C2=A0

Refe= rences to the =E2=80=9COcado Group=E2=80=9D are to Ocado Group plc (registe= red in England and Wales with number 7098618) and its subsidiary undertakin= gs (as that expression is defined in the Companies Act 2006) from time to t= ime.=C2=A0 The registered office of Ocado Group plc is Titan Court, 3 Bisho= ps Square, Hatfield Business Park, Hatfield, Herts. AL10 9NE.

--001a114b118234afab053691836f--