httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luca Toscano <toscano.l...@gmail.com>
Subject Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c
Date Fri, 01 Jul 2016 16:32:49 GMT
Hi Yann!

2016-07-01 18:02 GMT+02:00 Yann Ylavic <ylavic.dev@gmail.com>:

> On Fri, Jul 1, 2016 at 5:00 PM,  <elukey@apache.org> wrote:
> > Author: elukey
> > Date: Fri Jul  1 15:00:42 2016
> > New Revision: 1750953
> >
> > URL: http://svn.apache.org/viewvc?rev=1750953&view=rev
> > Log:
> > Fixed typo in log message, wrong RFC mentioned.
> >
> > Modified:
> >     httpd/httpd/trunk/server/util_script.c
> >
> > Modified: httpd/httpd/trunk/server/util_script.c
> > URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util_script.c?rev=1750953&r1=1750952&r2=1750953&view=diff
> >
> ==============================================================================
> > --- httpd/httpd/trunk/server/util_script.c (original)
> > +++ httpd/httpd/trunk/server/util_script.c Fri Jul  1 15:00:42 2016
> > @@ -679,7 +679,7 @@ AP_DECLARE(int) ap_scan_script_header_er
> >                          apr_rfc822_date(last_modified_datestr,
> last_modified_date);
> >                          ap_log_rerror(SCRIPT_LOG_MARK, APLOG_TRACE1, 0,
> r,
> >                                        "The Last-Modified header value
> '%s' "
> > -                                      "(parsed as RFC882/RFC1123
> datetime, "
> > +                                      "(parsed as RFC822/RFC1123
> datetime, "
> >                                        "that assumes the GMT timezone) "
> >                                        "has been replaced with: '%s'. "
> >                                        "An origin server with a clock
> must not send "
>
> This message is possibly too long, you shouldn't cite the RFC, IMHO.
> Something like "The Last-Modified header value '%s' (in the future)
> has been replaced with '%s'" is probably enough.
>

Thanks a lot for the review. This error message is the result of a long
email thread in users@ to make very clear that a Last-Modified value sent
from FCGI/CGI is assumed to be in GMT because of what stated in
RFC822/RFC1123. Maybe something like the following could work better?

"The Last-Modified header value '%s' (parsed assuming the GMT timezone) has
been replaced with '%s' because considered in the future."

Regards,

Luca

Mime
View raw message