Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6785F200B26 for ; Mon, 27 Jun 2016 23:13:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 664E7160A5B; Mon, 27 Jun 2016 21:13:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 88737160A54 for ; Mon, 27 Jun 2016 23:13:15 +0200 (CEST) Received: (qmail 19358 invoked by uid 500); 27 Jun 2016 21:13:09 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 19348 invoked by uid 99); 27 Jun 2016 21:13:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jun 2016 21:13:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0F5B8180481 for ; Mon, 27 Jun 2016 21:13:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.021 X-Spam-Level: X-Spam-Status: No, score=-0.021 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ayBSuGNth-bP for ; Mon, 27 Jun 2016 21:13:07 +0000 (UTC) Received: from mail-qt0-f176.google.com (mail-qt0-f176.google.com [209.85.216.176]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8DE025F33E for ; Mon, 27 Jun 2016 21:13:07 +0000 (UTC) Received: by mail-qt0-f176.google.com with SMTP id w59so28643553qtd.3 for ; Mon, 27 Jun 2016 14:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Eln2hyIC7T0hVhFL0VG+9QLoZAScIw9mfPHWAm9H23g=; b=FIto4iFJidorU5/y80yBMRqofLKUNWKEwfSMvpg1KYgGw8HI72/3eRtKopxf4lkuqx 7qACcIhh18mBwVM5LgrW9oVZEWWt/FUazdIWIWHWC/nyB0frGbfAb6GS2As/Lj4MgfxM TLYzVBoj3OWDRUZ+ZaffcltYHM73+aJMC9C25nQQiR6It/UUyfRaQ81HNHTbBOCSwFnb j1JVSEzZKuzX6/pRsh1PJHQwLMvPwyGFI91S+wooAs/UL0IQz2M8p9BoayPu+aNxL2Yp VUQhSXdVS84wpxpOe/iR9tsOL/pngKS7d+gukxELb3QkDjFUpvN6y3QDKkfi6aw+CT2Q 4dCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Eln2hyIC7T0hVhFL0VG+9QLoZAScIw9mfPHWAm9H23g=; b=VYiPscRCDImSHIbY8X8WrnhDh7ZxdcOOVQz05iU3Vd3mWxMbQ/3eiG6elqZOuoKsyH +IILavorKP+GIQs3ip/Q2NBoVEE5aId4EsJbEZKQAKVvkhz+XJl8jy1Jhvv6JOCTGAx3 Oq+rKCiQszMWg+RRB79s0ThZMqXf/v+/0445j841bsku5xx1cORFs2lZXZ1xaH+iG8r4 CLPzDEo3+LfGTSJU54gf0TxkuZPHbmXltulNJbf2Hp0MHDLBWCYpSsLwftrHygaGr5GV Yj+la1XB0OO8tyPwRDq/BuqbHMNKCAJ25WRdUBdhtvRJaV9xbtrhTKUsqhNwPTgCpUBo 6q9w== X-Gm-Message-State: ALyK8tKBjVcNQC3chGhRytW6Y/jEEROtL3BGF5fv2Io7fprijwPWOlJcpwCKMlSqmrHdZoV7FPwirbot180m+w== X-Received: by 10.200.55.37 with SMTP id o34mr27893350qtb.70.1467061981177; Mon, 27 Jun 2016 14:13:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.10.5 with HTTP; Mon, 27 Jun 2016 14:13:00 -0700 (PDT) In-Reply-To: References: <20160627172613.E60353A0096@svn01-us-west.apache.org> <544127A4-B8C2-4A6C-A522-D09B250B54A5@jaguNET.com> From: Yann Ylavic Date: Mon, 27 Jun 2016 23:13:00 +0200 Message-ID: Subject: Re: svn commit: r1750392 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number include/ap_mmn.h modules/proxy/mod_proxy.h modules/proxy/mod_proxy_ajp.c modules/proxy/mod_proxy_fcgi.c modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c To: httpd-dev Content-Type: multipart/mixed; boundary=001a11398234408e2b053648fc6f archived-at: Mon, 27 Jun 2016 21:13:16 -0000 --001a11398234408e2b053648fc6f Content-Type: text/plain; charset=UTF-8 On Mon, Jun 27, 2016 at 10:25 PM, Yann Ylavic wrote: > I thought we could later follow up on this change and optimize these > by using the new tmp_bb field (cleanup is faster than > create/destroy)... Something like the attached patch. --001a11398234408e2b053648fc6f Content-Type: text/plain; charset=US-ASCII; name="proxy_tmp_bb.diff" Content-Disposition: attachment; filename="proxy_tmp_bb.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ipyitig80 SW5kZXg6IG1vZHVsZXMvcHJveHkvbW9kX3Byb3h5X2h0dHAuYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBtb2R1 bGVzL3Byb3h5L21vZF9wcm94eV9odHRwLmMJKHJldmlzaW9uIDE3NTAzOTIpCisrKyBtb2R1bGVz L3Byb3h5L21vZF9wcm94eV9odHRwLmMJKHdvcmtpbmcgY29weSkKQEAgLTEyNTMsNyArMTI1Myw3 IEBAIGludCBhcF9wcm94eV9odHRwX3Byb2Nlc3NfcmVzcG9uc2UoYXByX3Bvb2xfdCAqIHAsCiAg ICAgY29uc3QgY2hhciAqYnVmOwogICAgIGNoYXIga2VlcGNoYXI7CiAgICAgYXByX2J1Y2tldCAq ZTsKLSAgICBhcHJfYnVja2V0X2JyaWdhZGUgKmJiLCAqdG1wX2JiOworICAgIGFwcl9idWNrZXRf YnJpZ2FkZSAqYmI7CiAgICAgYXByX2J1Y2tldF9icmlnYWRlICpwYXNzX2JiOwogICAgIGludCBs ZW4sIGJhY2thc3N3YXJkczsKICAgICBpbnQgaW50ZXJpbV9yZXNwb25zZSA9IDA7IC8qIG5vbi16 ZXJvIHdoaWxzdCBpbnRlcmltIDF4eCByZXNwb25zZXMKQEAgLTEzMDYsMTYgKzEzMDYsMTcgQEAg aW50IGFwX3Byb3h5X2h0dHBfcHJvY2Vzc19yZXNwb25zZShhcHJfcG9vbF90ICogcCwKICAgICBi YWNrZW5kLT5yLT5wcm94eXJlcSA9IFBST1hZUkVRX1JFU1BPTlNFOwogICAgIGFwcl90YWJsZV9z ZXRuKHItPm5vdGVzLCAicHJveHktc291cmNlLXBvcnQiLCBhcHJfcHNwcmludGYoci0+cG9vbCwg IiVodSIsCiAgICAgICAgICAgICAgICAgICAgb3JpZ2luLT5sb2NhbF9hZGRyLT5wb3J0KSk7Ci0g ICAgdG1wX2JiID0gYXByX2JyaWdhZGVfY3JlYXRlKHAsIGMtPmJ1Y2tldF9hbGxvYyk7CiAgICAg ZG8gewogICAgICAgICBhcHJfc3RhdHVzX3QgcmM7CiAKICAgICAgICAgYXByX2JyaWdhZGVfY2xl YW51cChiYik7CiAKLSAgICAgICAgcmMgPSBhcF9wcm94eWdldGxpbmUodG1wX2JiLCBidWZmZXIs IHNpemVvZihidWZmZXIpLCBiYWNrZW5kLT5yLCAwLCAmbGVuKTsKKyAgICAgICAgcmMgPSBhcF9w cm94eWdldGxpbmUoYmFja2VuZC0+dG1wX2JiLCBidWZmZXIsIHNpemVvZihidWZmZXIpLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBiYWNrZW5kLT5yLCAwLCAmbGVuKTsKICAgICAgICAg aWYgKGxlbiA9PSAwKSB7CiAgICAgICAgICAgICAvKiBoYW5kbGUgb25lIHBvdGVudGlhbCBzdHJh eSBDUkxGICovCi0gICAgICAgICAgICByYyA9IGFwX3Byb3h5Z2V0bGluZSh0bXBfYmIsIGJ1ZmZl ciwgc2l6ZW9mKGJ1ZmZlciksIGJhY2tlbmQtPnIsIDAsICZsZW4pOworICAgICAgICAgICAgcmMg PSBhcF9wcm94eWdldGxpbmUoYmFja2VuZC0+dG1wX2JiLCBidWZmZXIsIHNpemVvZihidWZmZXIp LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmFja2VuZC0+ciwgMCwgJmxlbik7 CiAgICAgICAgIH0KICAgICAgICAgaWYgKGxlbiA8PSAwKSB7CiAgICAgICAgICAgICBhcF9sb2df cmVycm9yKEFQTE9HX01BUkssIEFQTE9HX0VSUiwgcmMsIHIsIEFQTE9HTk8oMDExMDIpCkluZGV4 OiBtb2R1bGVzL3Byb3h5L3Byb3h5X3V0aWwuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBtb2R1bGVzL3Byb3h5 L3Byb3h5X3V0aWwuYwkocmV2aXNpb24gMTc1MDM5MikKKysrIG1vZHVsZXMvcHJveHkvcHJveHlf dXRpbC5jCSh3b3JraW5nIGNvcHkpCkBAIC0xMjk4LDYgKzEyOTgsNyBAQCBQUk9YWV9ERUNMQVJF KGFwcl9zdGF0dXNfdCkgYXBfcHJveHlfaW5pdGlhbGl6ZV9iYQogc3RhdGljIHZvaWQgc29ja2V0 X2NsZWFudXAocHJveHlfY29ubl9yZWMgKmNvbm4pCiB7CiAgICAgY29ubi0+c29jayA9IE5VTEw7 CisgICAgY29ubi0+dG1wX2JiID0gTlVMTDsKICAgICBjb25uLT5jb25uZWN0aW9uID0gTlVMTDsK ICAgICBjb25uLT5zc2xfaG9zdG5hbWUgPSBOVUxMOwogICAgIGFwcl9wb29sX2NsZWFyKGNvbm4t PnNjcG9vbCk7CkBAIC0xNDAxLDcgKzE0MDIsNiBAQCBzdGF0aWMgYXByX3N0YXR1c190IGNvbm5l Y3Rpb25fY2xlYW51cCh2b2lkICp0aGVjbwogUFJPWFlfREVDTEFSRShhcHJfc3RhdHVzX3QpIGFw X3Byb3h5X3NzbF9jb25uZWN0aW9uX2NsZWFudXAocHJveHlfY29ubl9yZWMgKmNvbm4sCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBy ZXF1ZXN0X3JlYyAqcikKIHsKLSAgICBhcHJfYnVja2V0X2JyaWdhZGUgKmJiOwogICAgIGFwcl9z dGF0dXNfdCBydjsKIAogICAgIC8qCkBAIC0xNDEzLDIyICsxNDEzLDIxIEBAIFBST1hZX0RFQ0xB UkUoYXByX3N0YXR1c190KSBhcF9wcm94eV9zc2xfY29ubmVjdGlvCiAgICAgICogcHJvY2Vzc2Vk LiBXZSBkb24ndCBleHBlY3QgYW55IGRhdGEgdG8gYmUgaW4gdGhlIHJldHVybmVkIGJyaWdhZGUu CiAgICAgICovCiAgICAgaWYgKGNvbm4tPnNvY2sgJiYgY29ubi0+Y29ubmVjdGlvbikgewotICAg ICAgICBiYiA9IGFwcl9icmlnYWRlX2NyZWF0ZShyLT5wb29sLCByLT5jb25uZWN0aW9uLT5idWNr ZXRfYWxsb2MpOwotICAgICAgICBydiA9IGFwX2dldF9icmlnYWRlKGNvbm4tPmNvbm5lY3Rpb24t PmlucHV0X2ZpbHRlcnMsIGJiLAorICAgICAgICBydiA9IGFwX2dldF9icmlnYWRlKGNvbm4tPmNv bm5lY3Rpb24tPmlucHV0X2ZpbHRlcnMsIGNvbm4tPnRtcF9iYiwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBBUF9NT0RFX1JFQURCWVRFUywgQVBSX05PTkJMT0NLX1JFQUQsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgSFVHRV9TVFJJTkdfTEVOKTsKICAgICAgICAgaWYgKChydiAh PSBBUFJfU1VDQ0VTUykgJiYgIUFQUl9TVEFUVVNfSVNfRUFHQUlOKHJ2KSkgewogICAgICAgICAg ICAgc29ja2V0X2NsZWFudXAoY29ubik7CiAgICAgICAgIH0KLSAgICAgICAgaWYgKCFBUFJfQlJJ R0FERV9FTVBUWShiYikpIHsKKyAgICAgICAgaWYgKCFBUFJfQlJJR0FERV9FTVBUWShjb25uLT50 bXBfYmIpKSB7CiAgICAgICAgICAgICBhcHJfb2ZmX3QgbGVuOwogCi0gICAgICAgICAgICBydiA9 IGFwcl9icmlnYWRlX2xlbmd0aChiYiwgMCwgJmxlbik7CisgICAgICAgICAgICBydiA9IGFwcl9i cmlnYWRlX2xlbmd0aChjb25uLT50bXBfYmIsIDAsICZsZW4pOwogICAgICAgICAgICAgYXBfbG9n X3JlcnJvcihBUExPR19NQVJLLCBBUExPR19UUkFDRTMsIHJ2LCByLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAiU1NMIGNsZWFudXAgYnJpZ2FkZSBjb250YWluZWQgJSIKICAgICAgICAgICAg ICAgICAgICAgICAgICAgQVBSX09GRl9UX0ZNVCAiIGJ5dGVzIG9mIGRhdGEuIiwgbGVuKTsKKyAg ICAgICAgICAgIGFwcl9icmlnYWRlX2NsZWFudXAoY29ubi0+dG1wX2JiKTsKICAgICAgICAgfQot ICAgICAgICBhcHJfYnJpZ2FkZV9kZXN0cm95KGJiKTsKICAgICB9CiAgICAgcmV0dXJuIEFQUl9T VUNDRVNTOwogfQpAQCAtMjcxMiw5ICsyNzExLDYgQEAgUFJPWFlfREVDTEFSRShhcHJfc3RhdHVz X3QpIGFwX3Byb3h5X2NoZWNrX2JhY2tlbmQKIAogICAgIGlmIChjb25uLT5jb25uZWN0aW9uKSB7 CiAgICAgICAgIGNvbm5fcmVjICpjID0gY29ubi0+Y29ubmVjdGlvbjsKLSAgICAgICAgaWYgKGNv bm4tPnRtcF9iYiA9PSBOVUxMKSB7Ci0gICAgICAgICAgICBjb25uLT50bXBfYmIgPSBhcHJfYnJp Z2FkZV9jcmVhdGUoYy0+cG9vbCwgYy0+YnVja2V0X2FsbG9jKTsKLSAgICAgICAgfQogICAgICAg ICBydiA9IGFwX2dldF9icmlnYWRlKGMtPmlucHV0X2ZpbHRlcnMsIGNvbm4tPnRtcF9iYiwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBBUF9NT0RFX1NQRUNVTEFUSVZFLCBBUFJfTk9OQkxP Q0tfUkVBRCwgMSk7CiAgICAgICAgIGlmIChydiA9PSBBUFJfU1VDQ0VTUyAmJiBleHBlY3RfZW1w dHkpIHsKQEAgLTMwNDYsNiArMzA0Miw3IEBAIHN0YXRpYyBpbnQgcHJveHlfY29ubmVjdGlvbl9j cmVhdGUoY29uc3QgY2hhciAqcHJvCiAgICAgfQogCiAgICAgYnVja2V0X2FsbG9jID0gYXByX2J1 Y2tldF9hbGxvY19jcmVhdGUoY29ubi0+c2Nwb29sKTsKKyAgICBjb25uLT50bXBfYmIgPSBhcHJf YnJpZ2FkZV9jcmVhdGUoY29ubi0+c2Nwb29sLCBidWNrZXRfYWxsb2MpOwogICAgIC8qCiAgICAg ICogVGhlIHNvY2tldCBpcyBub3cgb3BlbiwgY3JlYXRlIGEgbmV3IGJhY2tlbmQgc2VydmVyIGNv bm5lY3Rpb24KICAgICAgKi8K --001a11398234408e2b053648fc6f--