Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 32BEA200B26 for ; Mon, 27 Jun 2016 17:14:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 31486160A5B; Mon, 27 Jun 2016 15:14:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 55CAD160A54 for ; Mon, 27 Jun 2016 17:14:25 +0200 (CEST) Received: (qmail 75260 invoked by uid 500); 27 Jun 2016 15:14:24 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 75250 invoked by uid 99); 27 Jun 2016 15:14:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jun 2016 15:14:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id ED5FB18056A for ; Mon, 27 Jun 2016 15:14:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.298 X-Spam-Level: * X-Spam-Status: No, score=1.298 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=rowe-clan-net.20150623.gappssmtp.com Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id eR_6ht5P1ndj for ; Mon, 27 Jun 2016 15:14:22 +0000 (UTC) Received: from mail-io0-f175.google.com (mail-io0-f175.google.com [209.85.223.175]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 448D15F23C for ; Mon, 27 Jun 2016 15:14:22 +0000 (UTC) Received: by mail-io0-f175.google.com with SMTP id g13so147671719ioj.1 for ; Mon, 27 Jun 2016 08:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowe-clan-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=14RE6FHztwSeVhPESCjwjPHnvapyY7Pc7WilMER+rio=; b=eKlIexFVI5UiaB3VHDLeCa8MuumRRf/+ZIFtnSleVyeMDuAb09An0iseDBLPmklxMM STF1e5drUqP9LbmF7jeX86kpLLfAB6zAivYxYJS68yrioiPP49lWY5OlajKwBcAlxLMf d9zXgeBmVW+Ljp9YAvpOU4qLjy2rAKTAY9wIddnu+xfDeuGLrecrRCv5LsfU/M46HBlg UFii0DwbtxcS2vpSRk+l76YTrA/TbpW1ucrCl5JYUHX7jDNeUrEmib9IJC2g7X6h0HM/ 0IvziQuZ4mkFt/zDw+glVBfZcD+xBUmYkKnuAs9I2wAhtJC4UPU0dvUrkjO9oZjCecQ+ pw4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=14RE6FHztwSeVhPESCjwjPHnvapyY7Pc7WilMER+rio=; b=lp80WmYky/Z8DMlOAPa4+GCXCSbQrrA+M3V6RpZUpCU5py164fbg1v7wFndZdpYQ2B opl+4bbqbOrK25v4Z3TxheZ4/nirQQtYxG1FAnJzvOcQVdYu7DOT88SCIK3mVdKVMLdT GShegZujwQI5GLxicXZjW/HdTaaJuNIVSYC2bdsOaAEiGtGxfHQ9KDH0sD1t/C3XGcqq 1mrMmP7KVPXKokwBOxs2/cnB6ScZYwM4+szUWJC1vMxCbgAi1pAW6HQH+8uDOA1MKmdh fLG4dan7m+6kTpsQjuSrGywWLRpEOV/qSBY3J5fGitBg58hBZqUklY7O0Y7sHzC5ZoaM /I1w== X-Gm-Message-State: ALyK8tIvweyufIlGzKBEg73P4ejgtmajRND1ngNQBF0c1dU2tHFN+3/t5PuNR2gknTRRw1CjNt9B1dE5mnTHbxGq MIME-Version: 1.0 X-Received: by 10.107.27.131 with SMTP id b125mr1276851iob.163.1467040455181; Mon, 27 Jun 2016 08:14:15 -0700 (PDT) Received: by 10.107.16.216 with HTTP; Mon, 27 Jun 2016 08:14:15 -0700 (PDT) Received: by 10.107.16.216 with HTTP; Mon, 27 Jun 2016 08:14:15 -0700 (PDT) In-Reply-To: <57713BDC.1090701@apache.org> References: <20160627134503.6F4033A0096@svn01-us-west.apache.org> <5771373F.20807@apache.org> <57713BDC.1090701@apache.org> Date: Mon, 27 Jun 2016 10:14:15 -0500 Message-ID: Subject: Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4 From: William A Rowe Jr To: httpd Content-Type: multipart/alternative; boundary=001a113fd5f433df63053643f998 archived-at: Mon, 27 Jun 2016 15:14:26 -0000 --001a113fd5f433df63053643f998 Content-Type: text/plain; charset=UTF-8 On Jun 27, 2016 9:44 AM, "Ruediger Pluem" wrote: > > > > On 06/27/2016 04:35 PM, William A Rowe Jr wrote: > > On Mon, Jun 27, 2016 at 9:25 AM, Ruediger Pluem > wrote: > > > > > > On 06/27/2016 03:45 PM, wrowe@apache.org wrote: > > > Author: wrowe > > > Date: Mon Jun 27 13:45:02 2016 > > > New Revision: 1750335 > > > > > > URL: http://svn.apache.org/viewvc?rev=1750335&view=rev > > > Log: > > > Ensure not-selected means 'no', once an APACHE_MODULE enable_foo is processed > > > > > > Modified: > > > httpd/httpd/trunk/acinclude.m4 > > > > > > Modified: httpd/httpd/trunk/acinclude.m4 > > > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/acinclude.m4?rev=1750335&r1=1750334&r2=1750335&view=diff > > > ============================================================================== > > > --- httpd/httpd/trunk/acinclude.m4 (original) > > > +++ httpd/httpd/trunk/acinclude.m4 Mon Jun 27 13:45:02 2016 > > > @@ -375,6 +375,8 @@ AC_DEFUN([APACHE_MODULE],[ > > > "$force_$1" != "no" ; then > > > enable_$1=$module_default > > > _apmod_extra_msg=" ($module_selection)" > > > + else > > > + enable_$1=no > > > > What if enable_$1 is set to shared by the the user of ./configure? Wouldn't that get overriden here? > > > > > > The valid cases of 'yes', 'shared', 'static', 'no', 'most' (??), 'maybe-all' (??), are all handled > > in the various if/elif cases above this change. > > I don't see the handling of 'shared' above, but maybe I missed it. Hence my question. I see static, yes, maybe-all, > most, but not shared. My eyes playing tricks on me, you are right. Running some various tests, hope to complete the fix this afternoon once I come up with any other obscure edge cases. > > The edge case of 'few' and 'reallyall' are not handled above, and we perhaps need to account > > for these? In any case, the old logic seems to always result in build-shared for unexpected > > values, no matter how silly they are (e.g. 'none'). > > > > Agreed that it should be fixed. I still don't understand what --enable-modules=few (etc) are even supposed to mean. --001a113fd5f433df63053643f998 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Jun 27, 2016 9:44 AM, "Ruediger Pluem" <rpluem@apache.org> wrote:
>
>
>
> On 06/27/2016 04:35 PM, William A Rowe Jr wrote:
> > On Mon, Jun 27, 2016 at 9:25 AM, Ruediger Pluem <rpluem@apache.org <mailto:rpluem@apache.org>> wrote:
> >
> >
> >=C2=A0 =C2=A0 =C2=A0On 06/27/2016 03:45 PM, wrowe@apache.org <mailto:wrowe@apache.org> wrote:
> >=C2=A0 =C2=A0 =C2=A0> Author: wrowe
> >=C2=A0 =C2=A0 =C2=A0> Date: Mon Jun 27 13:45:02 2016
> >=C2=A0 =C2=A0 =C2=A0> New Revision: 1750335
> >=C2=A0 =C2=A0 =C2=A0>
> >=C2=A0 =C2=A0 =C2=A0> URL: http://svn.apache.org/viewvc?rev=3D175033= 5&view=3Drev
> >=C2=A0 =C2=A0 =C2=A0> Log:
> >=C2=A0 =C2=A0 =C2=A0> Ensure not-selected means 'no', o= nce an APACHE_MODULE enable_foo is processed
> >=C2=A0 =C2=A0 =C2=A0>
> >=C2=A0 =C2=A0 =C2=A0> Modified:
> >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0httpd/httpd/trunk/acin= clude.m4
> >=C2=A0 =C2=A0 =C2=A0>
> >=C2=A0 =C2=A0 =C2=A0> Modified: httpd/httpd/trunk/acinclude.m4<= br> > >=C2=A0 =C2=A0 =C2=A0> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/aci= nclude.m4?rev=3D1750335&r1=3D1750334&r2=3D1750335&view=3Ddiff
> >=C2=A0 =C2=A0 =C2=A0> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >=C2=A0 =C2=A0 =C2=A0> --- httpd/httpd/trunk/acinclude.m4 (origi= nal)
> >=C2=A0 =C2=A0 =C2=A0> +++ httpd/httpd/trunk/acinclude.m4 Mon Ju= n 27 13:45:02 2016
> >=C2=A0 =C2=A0 =C2=A0> @@ -375,6 +375,8 @@ AC_DEFUN([APACHE_MODU= LE],[
> >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 "$force_$1" !=3D "no" ; then
> >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 enable_$1=3D$m= odule_default
> >=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 _apmod_extra_m= sg=3D" ($module_selection)"
> >=C2=A0 =C2=A0 =C2=A0> +=C2=A0 else
> >=C2=A0 =C2=A0 =C2=A0> +=C2=A0 =C2=A0 =C2=A0enable_$1=3Dno
> >
> >=C2=A0 =C2=A0 =C2=A0What if enable_$1 is set to shared by the the = user of ./configure? Wouldn't that get overriden here?
> >
> >
> > The valid cases of 'yes', 'shared', 'static&#= 39;, 'no', 'most' (??), 'maybe-all' (??), are all h= andled
> > in the various if/elif cases above this change.
>
> I don't see the handling of 'shared' above, but maybe I mi= ssed it. Hence my question. I see static, yes, maybe-all,
> most, but not shared.

My eyes playing tricks on me, you are right.

Running some various tests, hope to complete the fix this af= ternoon once I come up with any other obscure edge cases.

> > The edge case of 'few' and 'reallyall&= #39; are not handled above, and we perhaps need to account
> > for these? In any case, the old logic seems to always result in b= uild-shared for unexpected
> > values, no matter how silly they are (e.g. 'none').
> >
>
> Agreed that it should be fixed.

I still don't understand what --enable-modules=3Dfew (et= c) are even supposed to mean.

--001a113fd5f433df63053643f998--