httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marion & Christophe JAILLET <christophe.jail...@wanadoo.fr>
Subject Re: svn commit: r1747056 - in /httpd/httpd/branches/2.4.x: ./ STATUS modules/mappers/mod_rewrite.c
Date Tue, 07 Jun 2016 06:23:53 GMT


Le 07/06/2016 à 06:59, William A Rowe Jr a écrit :
> On Mon, Jun 6, 2016 at 3:10 PM, Marion & Christophe JAILLET 
> <christophe.jaillet@wanadoo.fr <mailto:christophe.jaillet@wanadoo.fr>> 
> wrote:
>
>     ap_casecmpstr breaks 2.4.x build.
>     Keep strncasecmp for now? (waiting for ap_cstr_casecmp[n])
>
>     Le 06/06/2016 à 21:11, jim@apache.org <mailto:jim@apache.org> a
>     écrit :
>
>         Author: jim
>         Date: Mon Jun  6 19:11:20 2016
>         New Revision: 1747056
>
>         URL: http://svn.apache.org/viewvc?rev=1747056&view=rev
>         Log:
>         Merge r1744206 from trunk:
>
>         mod_rewrite: adding h2:// and h2c:// proxy schemes to absolute
>         uri detection, patch by Evgeny Kotkov
>         Submitted by: icing
>         Reviewed/backported by: jim
>
>         Modified:
>              httpd/httpd/branches/2.4.x/   (props changed)
>              httpd/httpd/branches/2.4.x/STATUS
>          httpd/httpd/branches/2.4.x/modules/mappers/mod_rewrite.c
>
>
>         Modified: httpd/httpd/branches/2.4.x/STATUS
>         URL:
>         http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1747056&r1=1747055&r2=1747056&view=diff
>         ==============================================================================
>         --- httpd/httpd/branches/2.4.x/STATUS (original)
>         +++ httpd/httpd/branches/2.4.x/STATUS Mon Jun  6 19:11:20 2016
>         @@ -115,12 +115,6 @@ PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
>             [ start all new proposals below, under PATCHES PROPOSED. ]
>             - *) mod_rewrite: support new h2:// and h2c:// proxy url
>         schemes in detection
>         -     of absolute urls:
>         -     trunk patch: http://svn.apache.org/r1744206
>         -     2.4.x patch: trunk works
>         -     +1: icing, jim, covener
>
>
> Well, contrary to the commit message that failed to credit to the two 
> other
> reviewers, it did have 3 +1's... we are pretty specific on backport 
> policy.
>
> Is that a vote against, jallettc? If not, the backport remains valid.
>

No, it's not a vote against.
It is just a remark that we should move forward and either backport 
ap_cstr_casecmp[n] or decide to delay it to another release.

We are building 2.4.21, so breaking compilation for a few days is, IMHO, 
acceptable.


I will have limited time until end of the week to update my 
ap_cstr_casecmp[n] backport proposal.
So if anyone wants to update it before, do not hesitate.

CJ

Mime
View raw message