httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <>
Subject Re: mod_cache forgets to include cached headers when serving cached content under certain circumstances (2.2.x)
Date Mon, 23 May 2016 11:50:04 GMT
On Mon, May 23, 2016 at 6:24 AM, Rob Landrito <> wrote:
> The specific circumstance is described in a comment in mod_cache:
>     /* Hold the phone. Some servers might allow us to cache a 2xx, but
>      * then make their 304 responses non cacheable. This leaves us in a
>      * sticky position. If the 304 is in answer to our own conditional
>      * request, we cannot send this 304 back to the client because the
>      * client isn't expecting it. Instead, our only option is to respect
>      * the answer to the question we asked (has it changed, answer was
>      * no) and return the cached item to the client, and then respect
>      * the uncacheable nature of this 304 by allowing the remove_url
>      * filter to kick in and remove the cached entity.
>      */
> The code proceeds to push the cached content onto the bucket brigade but
> neglects to apply the matching cached headers.
> Originally I thought the solution would be to simply add the cached
> headers but in the 2.4.x branch, it seems that this case is handled by
> re-requesting the resource without the conditional.  Should this code be
> backported into the the 2.2.x branch ?

Should/could yes. Not a ton of developer capacity on 2.2.x, though.

Eric Covener

View raw message