httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c
Date Fri, 13 May 2016 17:44:58 GMT
On Fri, May 13, 2016 at 7:25 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> On Fri, May 13, 2016 at 6:57 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>>
>> But for the above cases or an error while reading/validating the
>> headers or running post_read_request(), we finally call ap_die() or
>> ap_send_error_response().
>> I think we should report SERVER_BUSY_WRITE with r before those calls,
>> and use NULL for SERVER_BUSY_LOG.
>
> For the REQUEST_TIME_OUT case, we may need something like the below too.
> The goal would be to answer something to the client (408) if the
> timeout occurs with some request line byte(s) received (that an
> invalid request but still a request), and report the r (even "NULL"
> for the first empty request on the connection).

Just to be clear, full proposed patch (including yours) attached.

Mime
View raw message