Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CACsi2527EYRU5WfGrUFWOTp=V75qGZRuBKM8+wvEKwbb2ra4UQ@mail.gmail.com>
References: <20160427184150.5A41B3A0734@svn01-us-west.apache.org>
	<CAKQ1sVOZCpQqVhfohWgAEW4Ed3LrnrDFU1T8u7JLuVvf1Kz=Zw@mail.gmail.com>
	<CACsi253VGC7uFJK8QBcG1=zW0kszbyRaoB=aOsEStcHogmUe=g@mail.gmail.com>
	<CAKQ1sVP9So7svupARoofmc8zQ8yo1YW43=8=qWBDsnom_JPVMg@mail.gmail.com>
	<CACsi2527EYRU5WfGrUFWOTp=V75qGZRuBKM8+wvEKwbb2ra4UQ@mail.gmail.com>
Date: Thu, 28 Apr 2016 22:00:09 +0200
Message-ID: 
 <CAKQ1sVOxAzjjOK11zBtJT0gc0ngv_KuQUw+dTKsL5RqeBxyeWw@mail.gmail.com>
Subject: Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/
 server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/
 server/mpm/winnt/ server/mpm/worker/
From: Yann Ylavic <ylavic.dev@gmail.com>
To: httpd-dev <dev@httpd.apache.org>
Content-Type: text/plain; charset=UTF-8

On Thu, Apr 28, 2016 at 5:22 PM, William A Rowe Jr <wrowe@rowe-clan.net> wrote:
>
> What I meant is that the request line *MUST* be touched - wiped
> clean - for any status_from_conn(c) request.
>
> When we say we preserve the most recent state of the worker in
> the scoreboard, that old request line is gone.  Every time we are
> doing a conn-based refresh of that worker status, the req-based
> data is no longer relevant and needs to go away.

OK, I'm fine with this, much prefered over mixing (which finally I
introduced in my incomplete revert, understood ;)

>
> See
> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/server/scoreboard.c?r1=1239125&r2=1741240&diff_format=h
>
> for the delta between 2.4.1 and 2.4.broken (current state).
>
>          else if (c) {
> -            apr_cpystrn(ws->client, ap_get_remote_host(c, NULL,
> -                        REMOTE_NOLOOKUP, NULL), sizeof(ws->client));
> -            ws->request[0]='\0';
> -            ws->vhost[0]='\0';

Indeed, I missed that, too much influenced by the original report
about blanks introduced in 2.4.20, but that was only about the client
IP, not the vhost/request-line which have always been blank in
SERVER_BUSY_READ...

Your proposed backport looks good to me now, thanks for your patience :)