Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: <99A08372-9190-4E95-BA0D-C4B9188E1EEA@jaguNET.com>
References: <20160419091944.83F4A3A022C@svn01-us-west.apache.org>
	<CACsi2505OBEyTmc+SX55SkMBbogRKehUxs9d4p_O8fiD4G0tXA@mail.gmail.com>
	<CACsi250=9-GUZviZ2Vw5zhx2YozvXp2fbiXRtoP7QiLf1ouq3A@mail.gmail.com>
	<CAKQ1sVP9ro7KOs+jy7R=_oUdo0s2MeA52Cq4YeiX+aSdzs4peQ@mail.gmail.com>
	<CACsi251p-j+W15c6FmB4s=2dQQCHRBMohGdQAgUk8F5uOOSkrQ@mail.gmail.com>
	<824B8C67-22EF-4D80-8E91-54AC77F3D747@greenbytes.de>
	<99A08372-9190-4E95-BA0D-C4B9188E1EEA@jaguNET.com>
Date: Wed, 27 Apr 2016 08:43:22 -0500
Message-ID: 
 <CACsi253j3GbXa-cTWmCjg-MoZ3McyATYOZn6pJfSt1wELZfXhg@mail.gmail.com>
Subject: Re: svn commit: r1739876 - /httpd/httpd/branches/2.4.x/STATUS
From: William A Rowe Jr <wrowe@rowe-clan.net>
To: httpd <dev@httpd.apache.org>
Content-Type: multipart/alternative; boundary=047d7bdc0a84e70ed605317797df

--047d7bdc0a84e70ed605317797df
Content-Type: text/plain; charset=UTF-8

I'm not certain the error is -in- scoreboard.c.

Suspecting that we used to call ap_update_child_status[_xxx] with the
NULL req/conn rec pointer when we were idling for keepalive or ending the
request.
It seems we may now be calling it in these situations with a now-NULL
req_rec
and the dying/idling conn_rec pointer, causing the request value to null
out (or
calling it with a descr pointer to "\0").


On Wed, Apr 27, 2016 at 7:54 AM, Jim Jagielski <jim@jagunet.com> wrote:

> +1...
>
> I had just applied the patch in STATUS w/o seeing this thread.
> Best to just revert this all and get back to 2.4.18 behavior
> (and code)
>
> > On Apr 27, 2016, at 12:40 AM, Stefan Eissing <
> stefan.eissing@greenbytes.de> wrote:
> >
> >
> >
> >> Am 27.04.2016 um 03:53 schrieb William A Rowe Jr <wrowe@rowe-clan.net>:
> >>
> >>
> >> My gut instinct is to propose scoreboard.c for a full svn revert back
> >> to a working state,
> >
> > I did not realize that it is that deep of a mess now. Please revert,
> uncomment the new calls use in http2 and I'll find another approach there.
> >
> > It seems that there are a lot of expectations on how this part of the
> server behaves, but no way to verify any changes/additions against them for
> a newbie like me.
> >
> > Since this whole h2 thing is experimental and needs to evolve based on
> user feedback, it better either use the extension possibilities of
> mod_status or come up with a new, separate approach that allows frequent
> changes.
> >
> > -Stefan
>
>

--047d7bdc0a84e70ed605317797df
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I&#39;m not certain the error is -in- scoreboard.c.<div><b=
r></div><div>Suspecting that we used to call<span style=3D"color:rgb(0,0,0)=
;font-family:monospace;font-size:medium;white-space:pre"> ap_update_child_s=
tatus[_xxx] </span>with the</div><div>NULL req/conn rec pointer when we wer=
e idling for keepalive or ending the request.</div><div>It seems we may now=
 be calling it in these situations with a now-NULL req_rec</div><div>and th=
e dying/idling conn_rec pointer, causing the request value to null out (or<=
/div><div>calling it with a descr pointer to &quot;\0&quot;).</div><div><br=
></div><div><br><div class=3D"gmail_quote">On Wed, Apr 27, 2016 at 7:54 AM,=
 Jim Jagielski <span dir=3D"ltr">&lt;<a href=3D"mailto:jim@jagunet.com" tar=
get=3D"_blank">jim@jagunet.com</a>&gt;</span> wrote:<br><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;bo=
rder-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">=
+1...<br>
<br>
I had just applied the patch in STATUS w/o seeing this thread.<br>
Best to just revert this all and get back to 2.4.18 behavior<br>
(and code)<br>
<div class=3D""><div class=3D"h5"><br>
&gt; On Apr 27, 2016, at 12:40 AM, Stefan Eissing &lt;<a href=3D"mailto:ste=
fan.eissing@greenbytes.de">stefan.eissing@greenbytes.de</a>&gt; wrote:<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt;&gt; Am 27.04.2016 um 03:53 schrieb William A Rowe Jr &lt;<a href=3D"ma=
ilto:wrowe@rowe-clan.net">wrowe@rowe-clan.net</a>&gt;:<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; My gut instinct is to propose scoreboard.c for a full svn revert b=
ack<br>
&gt;&gt; to a working state,<br>
&gt;<br>
&gt; I did not realize that it is that deep of a mess now. Please revert, u=
ncomment the new calls use in http2 and I&#39;ll find another approach ther=
e.<br>
&gt;<br>
&gt; It seems that there are a lot of expectations on how this part of the =
server behaves, but no way to verify any changes/additions against them for=
 a newbie like me.<br>
&gt;<br>
&gt; Since this whole h2 thing is experimental and needs to evolve based on=
 user feedback, it better either use the extension possibilities of mod_sta=
tus or come up with a new, separate approach that allows frequent changes.<=
br>
&gt;<br>
&gt; -Stefan<br>
<br>
</div></div></blockquote></div><br></div></div>

--047d7bdc0a84e70ed605317797df--