Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C90B19F81 for ; Tue, 1 Mar 2016 12:26:27 +0000 (UTC) Received: (qmail 87621 invoked by uid 500); 1 Mar 2016 12:26:26 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 87532 invoked by uid 500); 1 Mar 2016 12:26:26 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 87522 invoked by uid 99); 1 Mar 2016 12:26:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2016 12:26:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D33F21A0D13 for ; Tue, 1 Mar 2016 12:26:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.298 X-Spam-Level: X-Spam-Status: No, score=0.298 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id APsXWaINpGS9 for ; Tue, 1 Mar 2016 12:26:24 +0000 (UTC) Received: from mail1.bemta3.messagelabs.com (mail1.bemta3.messagelabs.com [195.245.230.168]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 7F5435FADB for ; Tue, 1 Mar 2016 12:26:23 +0000 (UTC) Received: from [195.245.230.51] by server-8.bemta-3.messagelabs.com id F6/AA-04050-96A85D65; Tue, 01 Mar 2016 12:26:17 +0000 X-Env-Sender: ruediger.pluem@vodafone.com X-Msg-Ref: server-12.tower-33.messagelabs.com!1456835176!18902921!1 X-Originating-IP: [195.232.244.133] X-StarScan-Received: X-StarScan-Version: 8.11; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25340 invoked from network); 1 Mar 2016 12:26:16 -0000 Received: from mailout01.vodafone.com (HELO mailout01.vodafone.com) (195.232.244.133) by server-12.tower-33.messagelabs.com with DHE-RSA-AES256-SHA encrypted SMTP; 1 Mar 2016 12:26:16 -0000 Received: from mailint03.vodafone.com (mailint03.vodafone.com [195.232.244.200]) by mailout01.vodafone.com (Postfix) with ESMTP id 3qDyP45LlWz1yBX for ; Tue, 1 Mar 2016 13:26:16 +0100 (CET) Received: from mailint03.vodafone.com (localhost [127.0.0.1]) by mailint03.vodafone.com (Postfix) with ESMTP id 3qDyP44RGGz16KG1 for ; Tue, 1 Mar 2016 13:26:16 +0100 (CET) Received: from VOEXC02W.internal.vodafone.com (voexc02w.dc-ratingen.de [145.230.101.22]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailint03.vodafone.com (Postfix) with ESMTPS id 3qDyP443wTz16K9W for ; Tue, 1 Mar 2016 13:26:16 +0100 (CET) Received: from VOEXM10W.internal.vodafone.com ([169.254.2.216]) by VOEXC02W.internal.vodafone.com ([145.230.101.22]) with mapi id 14.03.0224.002; Tue, 1 Mar 2016 13:26:16 +0100 From: =?iso-8859-1?Q?Pl=FCm=2C_R=FCdiger=2C_Vodafone_Group?= To: "dev@httpd.apache.org" Subject: RE: svn commit: r1732986 - /httpd/httpd/trunk/modules/proxy/proxy_util.c Thread-Topic: svn commit: r1732986 - /httpd/httpd/trunk/modules/proxy/proxy_util.c Thread-Index: AQHRc7GlqlwEUnFDu0Wwcf1q4UJ01J9Eg6Jw Date: Tue, 1 Mar 2016 12:26:15 +0000 Message-ID: References: <20160301012007.3D5093A024F@svn01-us-west.apache.org> <8C0ABDEA-FAAB-434A-91BF-735DCB7E8803@jaguNET.com> In-Reply-To: <8C0ABDEA-FAAB-434A-91BF-735DCB7E8803@jaguNET.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 > -----Original Message----- > From: Jim Jagielski [mailto:jim@jaguNET.com] > Sent: Dienstag, 1. M=E4rz 2016 12:58 > To: dev@httpd.apache.org > Cc: cvs@httpd.apache.org > Subject: Re: svn commit: r1732986 - > /httpd/httpd/trunk/modules/proxy/proxy_util.c >=20 > I'd prefer we use a define, eg: >=20 > #define PROXY_WORKER_RFC1035_SIZE 512 >=20 > rather than embedding magic numbers... +1 Regards R=FCdiger >=20 > > On Feb 29, 2016, at 8:20 PM, ylavic@apache.org wrote: > > > > Author: ylavic > > Date: Tue Mar 1 01:20:06 2016 > > New Revision: 1732986 > > > > URL: http://svn.apache.org/viewvc?rev=3D1732986&view=3Drev > > Log: > > mod_proxy: follow up to r1729826 + r1729847. > > Adjust stacked ssl_hostname maximum size. > > > > Modified: > > httpd/httpd/trunk/modules/proxy/proxy_util.c > > > > Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c > > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.c= ? > rev=3D1732986&r1=3D1732985&r2=3D1732986&view=3Ddiff > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D > > --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original) > > +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Tue Mar 1 01:20:06 > 2016 > > @@ -2721,7 +2721,7 @@ PROXY_DECLARE(int) ap_proxy_connect_back > > * restore any ssl_hostname for this connection set earlier > by > > * ap_proxy_determine_connection(). > > */ > > - char ssl_hostname[PROXY_WORKER_MAX_HOSTNAME_SIZE]; > > + char ssl_hostname[512]; /* host+domain names max (rfc1035- > 2.3.4) */ > > if (!conn->ssl_hostname || PROXY_STRNCPY(ssl_hostname, > > conn- > >ssl_hostname)) { > > ssl_hostname[0] =3D '\0'; > > > >