httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com>
Subject RE: svn commit: r1736251 - in /httpd/httpd/branches/2.4.x: ./ modules/http2/h2_filter.c
Date Wed, 23 Mar 2016 09:43:01 GMT
In http_log.h we have a similar problem and solve that either as a macro or as a function
depending on our capabilities:


#ifdef AP_HAVE_C99
/* need additional step to expand APLOG_MARK first */
#define ap_log_error(...) ap_log_error__(__VA_ARGS__)
/* need server_rec *sr = ... for the case if s is verbatim NULL */
#define ap_log_error__(file, line, mi, level, status, s, ...)           \
    do { const server_rec *sr__ = s; if (APLOG_MODULE_IS_LEVEL(sr__, mi, level)) \
             ap_log_error_(file, line, mi, level, status, sr__, __VA_ARGS__);    \
    } while(0)
#else
#define ap_log_error ap_log_error_
#endif
AP_DECLARE(void) ap_log_error_(const char *file, int line, int module_index,
                               int level, apr_status_t status,
                               const server_rec *s, const char *fmt, ...)
                              __attribute__((format(printf,7,8)));
#endif

Regards

Rüdiger

> -----Original Message-----
> From: Stefan Eissing [mailto:stefan@eissing.org]
> Sent: Dienstag, 22. März 2016 21:59
> To: dev@httpd.apache.org
> Cc: cvs@httpd.apache.org
> Subject: Re: svn commit: r1736251 - in /httpd/httpd/branches/2.4.x: ./
> modules/http2/h2_filter.c
> 
> Thanks, Yann.
> 
> > Am 22.03.2016 um 21:48 schrieb ylavic@apache.org:
> >
> > Author: ylavic
> > Date: Tue Mar 22 20:48:47 2016
> > New Revision: 1736251
> >
> > URL: http://svn.apache.org/viewvc?rev=1736251&view=rev
> > Log:
> > Merge r1736250 from trunk:
> >
> > mod_http2: no variadic macro in C89, use equivalent function.
> > Reviewed/backported by: ylavic
> >
> > Modified:
> >    httpd/httpd/branches/2.4.x/   (props changed)
> >    httpd/httpd/branches/2.4.x/modules/http2/h2_filter.c
> >

Mime
View raw message