httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com>
Subject RE: svn commit: r1732986 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
Date Tue, 01 Mar 2016 12:26:15 GMT


> -----Original Message-----
> From: Jim Jagielski [mailto:jim@jaguNET.com]
> Sent: Dienstag, 1. März 2016 12:58
> To: dev@httpd.apache.org
> Cc: cvs@httpd.apache.org
> Subject: Re: svn commit: r1732986 -
> /httpd/httpd/trunk/modules/proxy/proxy_util.c
> 
> I'd prefer we use a define, eg:
> 
> #define PROXY_WORKER_RFC1035_SIZE 512
> 
> rather than embedding magic numbers...

+1

Regards

Rüdiger

> 
> > On Feb 29, 2016, at 8:20 PM, ylavic@apache.org wrote:
> >
> > Author: ylavic
> > Date: Tue Mar  1 01:20:06 2016
> > New Revision: 1732986
> >
> > URL: http://svn.apache.org/viewvc?rev=1732986&view=rev
> > Log:
> > mod_proxy: follow up to r1729826 + r1729847.
> > Adjust stacked ssl_hostname maximum size.
> >
> > Modified:
> >    httpd/httpd/trunk/modules/proxy/proxy_util.c
> >
> > Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c
> > URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.c?
> rev=1732986&r1=1732985&r2=1732986&view=diff
> >
> ==========================================================================
> ====
> > --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
> > +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Tue Mar  1 01:20:06
> 2016
> > @@ -2721,7 +2721,7 @@ PROXY_DECLARE(int) ap_proxy_connect_back
> >              * restore any ssl_hostname for this connection set earlier
> by
> >              * ap_proxy_determine_connection().
> >              */
> > -            char ssl_hostname[PROXY_WORKER_MAX_HOSTNAME_SIZE];
> > +            char ssl_hostname[512]; /* host+domain names max (rfc1035-
> 2.3.4) */
> >             if (!conn->ssl_hostname || PROXY_STRNCPY(ssl_hostname,
> >                                                      conn-
> >ssl_hostname)) {
> >                 ssl_hostname[0] = '\0';
> >
> >


Mime
View raw message