Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: event mpm and slave connections
From: Stefan Eissing <stefan.eissing@greenbytes.de>
In-Reply-To: 
 <CACsi253R7TNHF_xyYCURgMQ6YM7fcJVkUtxyE_=xuUwbFhYDPA@mail.gmail.com>
Date: Mon, 1 Feb 2016 10:27:57 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <BC11D1EE-3DE6-4229-B5F8-D365B68F095E@greenbytes.de>
References: <EA7D420F-B62E-4C06-A2F6-94661AE1E4DB@greenbytes.de>
 <CACsi253R7TNHF_xyYCURgMQ6YM7fcJVkUtxyE_=xuUwbFhYDPA@mail.gmail.com>
To: dev@httpd.apache.org

Sure, Bill. Love to have your feedback on this and make it work for =
mod_ftp, too.

> Am 30.01.2016 um 06:04 schrieb William A Rowe Jr =
<wrowe@rowe-clan.net>:
>=20
> If you can give me a few days (not httpd'ing again until=20
> late Sun eve) - this is very close to the issues we have
> in mod_ftp with the data connection/request aside the
> control connection.  The right patch will improve both
> sets of dirty hacks :)
>=20
> Thanks for the proposal!
>=20
> Bill
>=20
> On Fri, Jan 29, 2016 at 7:01 AM, Stefan Eissing =
<stefan.eissing@greenbytes.de> wrote:
> I would like to propose some additions to event that help me get rid =
of two ugly hacks in mod_http2:
>=20
> 1. Initialization of slave connections
>    event registers on pre_connection hook and checks if c is a slave =
(c->master) and if the connection state is either not there or the same =
as master (pointer copy). It then sets up a new cs using the slave =
connection pool.
>=20
> 2. Initialization of server config
>    event keeps in its private connection state parts the server =
configuration (queues for timeouts and keepalives) that are unique to =
each server because of Timeout and KeepAliveTimeout settings. Normally, =
theses are set on post_read_request hooks which is fine and well. On =
master connections however, these hooks may never get called so the =
server config remains stuck on the connections base server.
>    In the case of SNI however, we know which server this connection is =
intended for and should use its Timeouts. This is done by installing an =
early protocol_switch hook that sees connections updates and server_rec =
and initializes its connection state accordingly.
>=20
> Please vote on the attached patch. I do not want to mess with event =
without having some moral backup...
>=20
> -Stefan
>=20
>=20