httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1729826 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c
Date Thu, 11 Feb 2016 15:00:33 GMT
On Thu, Feb 11, 2016 at 3:14 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> On Thu, Feb 11, 2016 at 3:10 PM, Ruediger Pluem <rpluem@apache.org> wrote:
>>
>> conn->ssl_hostname might be allocated from conn->scpool.
>> So the pointer might be invalid after socket_cleanup(conn). So you need to apr_pstrdup
it first.
>> No real good idea which pool to use here.
>
> Oh, correct!
>
>> Probably create a temp subpool of conn->pool,
>> strdup, after socket_cleanup dup with conn->scpool and destroy tmp pool.
>
> Yes, possibly overkill, I have to find something else...

Maybe r1729847 is fine?

>
> Regards,
> Yann.

Mime
View raw message