httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1729826 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c
Date Thu, 11 Feb 2016 14:16:50 GMT
On Thu, Feb 11, 2016 at 3:12 PM, Stefan Eissing
<stefan.eissing@greenbytes.de> wrote:
>
>> Am 11.02.2016 um 15:10 schrieb Ruediger Pluem <rpluem@apache.org>:
>>
>>
>> conn->ssl_hostname might be allocated from conn->scpool.
>> So the pointer might be invalid after socket_cleanup(conn). So you need to apr_pstrdup
it first.
>> No real good idea which pool to use here. Probably create a temp subpool of conn->pool,
>> strdup, after socket_cleanup dup with conn->scpool and destroy tmp pool.
>
> I only dup'ed it once into a stack pointer. So, I used the r->pool for that.

But we don't have an 'r' in ap_proxy_connect_backend(), maybe a new
_ex() function is needed.

Mime
View raw message