httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From William A Rowe Jr <wr...@rowe-clan.net>
Subject Re: const char *--> char * clean-up
Date Thu, 04 Feb 2016 22:04:35 GMT
On Thu, Feb 4, 2016 at 3:49 PM, Christophe JAILLET <
christophe.jaillet@wanadoo.fr> wrote:

> Hi,
>
> in order to avoid the ugliness of things like:
>     r->protocol = (char*)"HTTP/1.0";
> does the following proposal makes sense to you?
>

This patch is needed on trunk, yes.

Does turning a "char *" to a "const char *" in a struct defined in
> include/httpd.h in considered as a API change?
>

It is.  (And the cast above was very, very wrong and would generally lead
to a segfault on manipulation of the char array members).

Whether folks used the mutability of the r->protocol array is anyone's
guess.
It certainly changes the API.

Mime
View raw message