httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r1729507 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy.c proxy/mod_proxy.h proxy/mod_proxy_ajp.c proxy/mod_proxy_http.c proxy/mod_proxy_wstunnel.c
Date Wed, 10 Feb 2016 21:06:26 GMT


On 02/10/2016 09:52 PM, Yann Ylavic wrote:
> On Wed, Feb 10, 2016 at 9:19 PM, Ruediger Pluem <rpluem@apache.org> wrote:
>>
>> On 02/10/2016 09:15 PM, Jim Jagielski wrote:
>>> It looks like the whole retry was removed :(
>>
>> If you look at the old code before r1729507 there wasn't any retry in the mod_proxy_wstunnel
case.
>> The loop had just one iteration. Hence my comment below.
> 
> Indeed, this was a fake loop, and still is..
> 
>> Why do we keep a loop at all?
> 
> I wanted to avoid a goto construction or early returns for the failing cases.

Interesting approach to solve this issue with a do while loop :-).
I guess we could use a goto as we do in other parts of the code for similar situations.

Regards

RĂ¼diger

Mime
View raw message