Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: <20160126125718.90E3E3A00E7@svn01-us-west.apache.org>
References: <20160126125718.90E3E3A00E7@svn01-us-west.apache.org>
Date: Wed, 27 Jan 2016 09:14:55 +0100
Message-ID: 
 <CAKQ1sVMuz7gGmPOfRDADn7ONNVLuK3SmcKyZupjGbJycUXS0nA@mail.gmail.com>
Subject: Re: svn commit: r1726787 -
 /httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c
From: Yann Ylavic <ylavic.dev@gmail.com>
To: httpd-dev <dev@httpd.apache.org>
Content-Type: text/plain; charset=UTF-8

On Tue, Jan 26, 2016 at 1:57 PM,  <rpluem@apache.org> wrote:
> Author: rpluem
> Date: Tue Jan 26 12:57:18 2016
> New Revision: 1726787
>
> URL: http://svn.apache.org/viewvc?rev=1726787&view=rev
> Log:
> * Transform the buckets to the correct lifetime of the brigade, connection and filter stack that processes it.

I'm not sure the buckets can be destroyed while in flight in
mod_proxy_wstunnel, unlike with mod_proxy_http where the backend
connection/request may be cleared before all data are out.

ISTM that this can't happen here because we flush out on every write
(btw that could be optimized to flush outside the loop).
So provided we clear the working brigade before leaving, isn't that
enough already?

Regards,
Yann.